1171633 - New toggle appears in settings when disconnecting account

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Robin Andersen [:tecgirl]]

A toggle will appear next to 'Version x.x' when disconnecting or signing into a FxA in Settings. 

In action: http://c.tecgirl.com/bVpw

Comment 1

[Aaron Train [:aaronmt]]

Just noticed this now and hit it on master.

Comment 3

[Bryan Munar (:bkmunar)]

I think this was fixed with Darrin's fix!

Comment 4

[Bryan Munar (:bkmunar)]

Attachment: Screen Shot 2015-07-02 at 2.56.36 PM.png

nope, just kidding hehe still needs to be fixed

Comment 5

[Bryan Munar (:bkmunar)]

^ above behavior was made when signing in and refreshing to sync O_O

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I'll take this one since I probably introduced it. (I added the first item with a UISwitch in it)

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/672

This patch resets the cell's `accessoryView` to `nil` when it is configured with the defaults. This is not the best solution. I think what really should happen is that instead of subclassing a `Setting` class, we should simply implement `UITableViewCell` subclasses for the individual items, with unique `reuseIdentifiers`. There is no need to put an extra abstraction on top of that.

Comment 8

[Stephan Leroux [:sleroux]]

Comment on attachment 8629406 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/672

Yup this works for now. When we move over to a subclass we can override the prepForReuse method to perform this resetting of values.