The default bug view has changed. See this FAQ.

bustage: mailnews/local/src/nsPop3Sink.cpp:63:85: error: 'PR_LOG' was not declared in this scope

RESOLVED FIXED in Thunderbird 41.0

Status

MailNews Core
Backend
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Magnus Melin, Assigned: ewong)

Tracking

({dogfood, regression})

Trunk
Thunderbird 41.0
dogfood, regression

Thunderbird Tracking Flags

(thunderbird41 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

2 years ago
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:63:85: error: 'PR_LOG' was not declared in this scope
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp: In member function 'virtual nsresult nsPop3Sink::BeginMailDelivery(bool, nsIMsgWindow*, bool*)':
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:231:80: error: 'PR_LOG' was not declared in this scope
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:236:74: error: 'PR_LOG' was not declared in this scope
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp: In member function 'virtual nsresult nsPop3Sink::EndMailDelivery(nsIPop3Protocol*)':
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:281:87: error: 'PR_LOG' was not declared in this scope
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp: In member function 'nsresult nsPop3Sink::ReleaseFolderLock()':
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:380:103: warning: left operand of comma operator has no effect [-Wunused-value]
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:380:111: error: 'PR_LOG' was not declared in this scope
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp: In member function 'virtual nsresult nsPop3Sink::AbortMailDelivery(nsIPop3Protocol*)':
/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/local/src/nsPop3Sink.cpp:407:89: error: 'PR_LOG' was not declared in this scope
make[5]: *** [nsPop3Sink.o] Error 1
make[5]: *** Waiting for unfinished jobs....
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Comment 16

2 years ago
This post on mozilla.dev.platform states that " PR_LOG* are deprecated. Use MOZ_LOG* instead."

https://groups.google.com/d/msg/mozilla.dev.platform/Vjylg8IQ6-Q/YxmUeTb68JMJ

Comment 17

2 years ago
Seems to be used in mailnews\ (sorry about the DOS slashes)
.\addrbook\src\nsAbOutlookDirectory.cpp
.\addrbook\src\nsAbOutlookDirFactory.cpp
.\addrbook\src\nsAbWinHelper.cpp
.\addrbook\src\nsMapiAddressBook.cpp
.\addrbook\src\nsWabAddressBook.cpp
.\base\src\nsMsgBiffManager.cpp
.\base\src\nsMsgCopyService.cpp
.\base\src\nsMsgPurgeService.cpp
.\compose\src\nsMsgComposeService.cpp
.\compose\src\nsSmtpProtocol.cpp
.\db\msgdb\src\nsMailDatabase.cpp
.\db\msgdb\src\nsMsgDatabase.cpp
.\db\msgdb\src\nsMsgOfflineImapOperation.cpp
.\extensions\bayesian-spam-filter\src\nsBayesianFilter.cpp
.\imap\src\nsAutoSyncManager.cpp
.\imap\src\nsAutoSyncState.cpp
.\imap\src\nsIMAPBodyShell.cpp
.\imap\src\nsImapMailFolder.cpp
.\imap\src\nsImapProtocol.cpp
.\imap\src\nsImapServerResponseParser.cpp
.\local\src\nsMailboxProtocol.cpp
.\local\src\nsMovemailService.cpp
.\local\src\nsMsgMaildirStore.cpp
.\local\src\nsPop3Protocol.cpp
.\local\src\nsPop3Sink.cpp
.\mapi\mapihook\src\msgMapiHook.cpp
.\mapi\mapihook\src\msgMapiImp.cpp
.\mime\emitters\nsMimeBaseEmitter.cpp
.\mime\src\nsCMS.cpp
.\mime\src\nsCMSSecureMessage.cpp
.\news\src\nsNNTPProtocol.cpp

Where else?

Comment 18

2 years ago
After replacing PR_LOG to MOZ_LOG this is the next error:

h:/mozilla-source/comm-central/mailnews/local/src/nsPop3Sink.cpp(63) :
error C2664: 'bool mozilla::detail::log_test(const PRLogModuleInfo *,mozilla::LogLevel)' : cannot convert argument 2 from 'PRLogModuleLevel' to 'mozilla::LogLevel'
Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast)

Comment 19

2 years ago
I have...

TODO.txt, C:\comm-central\ldap\xpcom, 6/4/2015 11:37:29 AM, 6959
nsLDAPConnection.cpp, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 23172
nsLDAPInternal.h, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 410
nsLDAPMessage.cpp, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 18733
nsLDAPOperation.cpp, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 29070
nsLDAPProtocolModule.cpp, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 5052
nsLDAPSecurityGlue.cpp, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 11874
nsLDAPService.cpp, C:\comm-central\ldap\xpcom\src, 6/4/2015 11:37:29 AM, 27883
nsAbOutlookDirectory.cpp, C:\comm-central\mailnews\addrbook\src, 6/4/2015 4:12:03 PM, 51856
nsAbOutlookDirFactory.cpp, C:\comm-central\mailnews\addrbook\src, 6/4/2015 11:37:31 AM, 2712
nsAbWinHelper.cpp, C:\comm-central\mailnews\addrbook\src, 6/4/2015 11:37:31 AM, 33912
nsMapiAddressBook.cpp, C:\comm-central\mailnews\addrbook\src, 6/4/2015 11:37:31 AM, 4821
nsWabAddressBook.cpp, C:\comm-central\mailnews\addrbook\src, 6/4/2015 11:37:31 AM, 3743
nsMsgBiffManager.cpp, C:\comm-central\mailnews\base\src, 6/4/2015 11:37:31 AM, 11065
nsMsgCopyService.cpp, C:\comm-central\mailnews\base\src, 6/4/2015 11:37:31 AM, 21602
nsMsgPurgeService.cpp, C:\comm-central\mailnews\base\src, 6/4/2015 11:37:31 AM, 19229
nsIMsgComposeService.idl, C:\comm-central\mailnews\compose\public, 6/4/2015 11:37:31 AM, 6419
nsMsgComposeService.cpp, C:\comm-central\mailnews\compose\src, 6/4/2015 11:37:31 AM, 58924
nsSmtpProtocol.cpp, C:\comm-central\mailnews\compose\src, 6/4/2015 11:37:31 AM, 71823
nsMailDatabase.cpp, C:\comm-central\mailnews\db\msgdb\src, 6/4/2015 11:37:31 AM, 11995
nsMsgDatabase.cpp, C:\comm-central\mailnews\db\msgdb\src, 6/4/2015 11:37:31 AM, 179583
nsMsgOfflineImapOperation.cpp, C:\comm-central\mailnews\db\msgdb\src, 6/4/2015 11:37:31 AM, 13783
nsBayesianFilter.cpp, C:\comm-central\mailnews\extensions\bayesian-spam-filter\src, 6/4/2015 11:37:31 AM, 90947
nsAutoSyncManager.cpp, C:\comm-central\mailnews\imap\src, 6/4/2015 4:22:04 PM, 44234
nsAutoSyncState.cpp, C:\comm-central\mailnews\imap\src, 6/4/2015 4:18:54 PM, 23275
nsIMAPBodyShell.cpp, C:\comm-central\mailnews\imap\src, 6/4/2015 11:37:31 AM, 41349
nsImapMailFolder.cpp, C:\comm-central\mailnews\imap\src, 6/4/2015 11:37:32 AM, 339413
nsImapProtocol.cpp, C:\comm-central\mailnews\imap\src, 6/4/2015 11:37:32 AM, 336156
nsImapServerResponseParser.cpp, C:\comm-central\mailnews\imap\src, 6/4/2015 11:37:32 AM, 105161
nsAppleMailImport.h, C:\comm-central\mailnews\import\applemail\src, 6/4/2015 11:37:32 AM, 2563
EudoraDebugLog.h, C:\comm-central\mailnews\import\eudora\src, 6/4/2015 11:37:32 AM, 852
OEDebugLog.h, C:\comm-central\mailnews\import\oexpress, 6/4/2015 11:37:32 AM, 772
OutlookDebugLog.h, C:\comm-central\mailnews\import\outlook\src, 6/4/2015 11:37:32 AM, 860
ImportDebug.h, C:\comm-central\mailnews\import\src, 6/4/2015 11:37:32 AM, 818
TextDebugLog.h, C:\comm-central\mailnews\import\text\src, 6/4/2015 11:37:32 AM, 818
nsVCardAddress.h, C:\comm-central\mailnews\import\vcard\src, 6/4/2015 11:37:32 AM, 1130
WMDebugLog.h, C:\comm-central\mailnews\import\winlivemail, 6/4/2015 11:37:32 AM, 772
nsMailboxProtocol.cpp, C:\comm-central\mailnews\local\src, 6/4/2015 11:37:32 AM, 25890
nsMovemailService.cpp, C:\comm-central\mailnews\local\src, 6/4/2015 11:37:32 AM, 20756
nsMsgMaildirStore.cpp, C:\comm-central\mailnews\local\src, 6/4/2015 11:37:32 AM, 46376
nsPop3Protocol.cpp, C:\comm-central\mailnews\local\src, 6/4/2015 11:37:32 AM, 133152
nsPop3Sink.cpp, C:\comm-central\mailnews\local\src, 6/4/2015 4:06:55 PM, 29451
msgMapiHook.cpp, C:\comm-central\mailnews\mapi\mapihook\src, 6/4/2015 11:37:32 AM, 28156
msgMapiImp.cpp, C:\comm-central\mailnews\mapi\mapihook\src, 6/4/2015 11:37:32 AM, 25684
nsMimeBaseEmitter.cpp, C:\comm-central\mailnews\mime\emitters, 6/4/2015 11:37:32 AM, 30576
nsCMS.cpp, C:\comm-central\mailnews\mime\src, 6/4/2015 11:37:32 AM, 27989
nsCMSSecureMessage.cpp, C:\comm-central\mailnews\mime\src, 6/4/2015 11:37:32 AM, 9988
nsNNTPProtocol.cpp, C:\comm-central\mailnews\news\src, 6/4/2015 11:37:32 AM, 136688
configure, C:\comm-central\mozilla, 6/4/2015 12:02:09 PM, 959450
configure.in, C:\comm-central\mozilla, 6/4/2015 11:52:45 AM, 314183
configure.in.d, C:\comm-central\mozilla\.hg\store\data, 6/4/2015 11:44:57 AM, 1009547
automation.py.in.d, C:\comm-central\mozilla\.hg\store\data\build, 6/4/2015 11:44:52 AM, 185003


Including the mozilla folder
automation.py.in, C:\comm-central\mozilla\build, 6/4/2015 11:52:43 AM, 35788
automationutils.py, C:\comm-central\mozilla\build, 6/4/2015 11:52:43 AM, 24544
remoteautomation.py, C:\comm-central\mozilla\build\mobile, 6/4/2015 11:52:43 AM, 17400
nsDocShell.cpp, C:\comm-central\mozilla\docshell\base, 6/4/2015 11:52:45 AM, 437890
nsContentSink.h, C:\comm-central\mozilla\dom\base, 6/4/2015 11:52:46 AM, 12729
nsDocument.cpp, C:\comm-central\mozilla\dom\base, 6/4/2015 11:52:46 AM, 386494
nsGlobalWindow.cpp, C:\comm-central\mozilla\dom\base, 6/4/2015 11:52:46 AM, 426119
ThirdPartyUtil.cpp, C:\comm-central\mozilla\dom\base, 6/4/2015 11:52:46 AM, 12319
DOMCameraManager.cpp, C:\comm-central\mozilla\dom\camera, 6/4/2015 11:52:49 AM, 12931
LoadManager.cpp, C:\comm-central\mozilla\dom\media\systemservices, 6/4/2015 11:52:55 AM, 5563
LoadMonitor.cpp, C:\comm-central\mozilla\dom\media\systemservices, 6/4/2015 11:52:55 AM, 18407
OpenSLESProvider.cpp, C:\comm-central\mozilla\dom\media\systemservices, 6/4/2015 11:52:55 AM, 5652
graph_latency.py, C:\comm-central\mozilla\dom\media\test, 6/4/2015 11:52:55 AM, 2623
energy_endpointer.cc, C:\comm-central\mozilla\dom\media\webspeech\recognition, 6/4/2015 11:52:56 AM, 14011
UDPSocket.h, C:\comm-central\mozilla\dom\network, 6/4/2015 11:52:57 AM, 5226
UDPSocketChild.cpp, C:\comm-central\mozilla\dom\network, 6/4/2015 11:52:57 AM, 9808
UDPSocketParent.cpp, C:\comm-central\mozilla\dom\network, 6/4/2015 11:52:57 AM, 12947
nsNPAPIPlugin.cpp, C:\comm-central\mozilla\dom\plugins\base, 6/4/2015 11:52:57 AM, 78245
nsPluginHost.cpp, C:\comm-central\mozilla\dom\plugins\base, 6/4/2015 11:52:57 AM, 123833
nsPluginLogging.h, C:\comm-central\mozilla\dom\plugins\base, 6/4/2015 11:52:57 AM, 3111
nsPluginStreamListenerPeer.cpp, C:\comm-central\mozilla\dom\plugins\base, 6/4/2015 11:52:57 AM, 41810
moz.build, C:\comm-central\mozilla\dom\plugins\ipc, 6/4/2015 11:52:58 AM, 3754
nsXULTemplateBuilder.cpp, C:\comm-central\mozilla\dom\xul\templates, 6/4/2015 11:53:05 AM, 89085
nsAuth.h, C:\comm-central\mozilla\extensions\auth, 6/4/2015 11:53:06 AM, 724
nsGIOProtocolHandler.cpp, C:\comm-central\mozilla\extensions\gio, 6/4/2015 11:53:06 AM, 35846
Logging.h, C:\comm-central\mozilla\gfx\2d, 6/4/2015 11:53:07 AM, 19160
LayersTypes.h, C:\comm-central\mozilla\gfx\layers, 6/4/2015 11:53:08 AM, 7996
LayerTransactionParent.cpp, C:\comm-central\mozilla\gfx\layers\ipc, 6/4/2015 11:53:09 AM, 33741
GeckoChildProcessHost.cpp, C:\comm-central\mozilla\ipc\glue, 6/4/2015 11:53:17 AM, 32958
mozJSComponentLoader.cpp, C:\comm-central\mozilla\js\xpconnect\loader, 6/4/2015 11:53:33 AM, 43339
XPCLog.cpp, C:\comm-central\mozilla\js\xpconnect\src, 6/4/2015 11:53:33 AM, 2052
XPCLog.h, C:\comm-central\mozilla\js\xpconnect\src, 6/4/2015 11:53:33 AM, 1979
nsIPresShell.h, C:\comm-central\mozilla\layout\base, 6/4/2015 11:53:34 AM, 67555
SelectionCarets.cpp, C:\comm-central\mozilla\layout\base, 6/4/2015 11:53:33 AM, 44283
TouchCaret.cpp, C:\comm-central\mozilla\layout\base, 6/4/2015 11:53:33 AM, 35043
nsFrame.cpp, C:\comm-central\mozilla\layout\generic, 6/4/2015 11:53:35 AM, 352977
nsFrame.h, C:\comm-central\mozilla\layout\generic, 6/4/2015 11:53:35 AM, 38951
nsPluginFrame.cpp, C:\comm-central\mozilla\layout\generic, 6/4/2015 11:53:35 AM, 61879
nsPrintEngine.cpp, C:\comm-central\mozilla\layout\printing, 6/4/2015 11:53:36 AM, 132751
WebRtcLog.cpp, C:\comm-central\mozilla\media\webrtc\signaling\src\common\browser_logging, 6/4/2015 11:54:04 AM, 5708
nsJARChannel.cpp, C:\comm-central\mozilla\modules\libjar, 6/4/2015 11:54:16 AM, 38684
all.js, C:\comm-central\mozilla\modules\libpref\init, 6/4/2015 11:54:16 AM, 208561
BackgroundFileSaver.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 41394
nsAsyncStreamCopier.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 11139
nsAutodialWin.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 17631
nsChannelClassifier.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 18385
nsInputStreamPump.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 26066
nsLoadGroup.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 36110
nsSocketTransportService2.h, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 10005
nsStandardURL.cpp, C:\comm-central\mozilla\netwerk\base, 6/4/2015 11:54:16 AM, 97044
nsCache.h, C:\comm-central\mozilla\netwerk\cache, 6/4/2015 11:54:16 AM, 1555
CacheLog.cpp, C:\comm-central\mozilla\netwerk\cache2, 6/4/2015 11:54:16 AM, 714
nsCookieService.cpp, C:\comm-central\mozilla\netwerk\cookie, 6/4/2015 11:54:16 AM, 155300
nsFtpProtocolHandler.cpp, C:\comm-central\mozilla\netwerk\protocol\ftp, 6/4/2015 11:54:16 AM, 12193
HttpLog.h, C:\comm-central\mozilla\netwerk\protocol\http, 6/4/2015 11:54:17 AM, 2014
nsResProtocolHandler.cpp, C:\comm-central\mozilla\netwerk\protocol\res, 6/4/2015 11:54:17 AM, 12893
moz.build, C:\comm-central\mozilla\netwerk\protocol\rtsp, 6/4/2015 11:54:17 AM, 2103
nsWyciwyg.h, C:\comm-central\mozilla\netwerk\protocol\wyciwyg, 6/4/2015 11:54:22 AM, 1415
DataChannel.cpp, C:\comm-central\mozilla\netwerk\sctp\datachannel, 6/4/2015 11:54:22 AM, 90214
nsFTPDirListingConv.cpp, C:\comm-central\mozilla\netwerk\streamconv\converters, 6/4/2015 11:54:24 AM, 11249
TestBlockingSocket.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 3670
TestIOThreads.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 1731
TestProtocols.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 25973
TestServ.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 3608
TestSocketTransport.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 10077
TestStreamChannel.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 5655
TestStreamLoader.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 2702
TestStreamPump.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 4842
TestStreamTransport.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 9475
TestUpload.cpp, C:\comm-central\mozilla\netwerk\test, 6/4/2015 11:54:26 AM, 4704
config.mk, C:\comm-central\mozilla\nsprpub\config, 6/4/2015 11:54:28 AM, 4272
arena.c, C:\comm-central\mozilla\nsprpub\lib\tests, 6/4/2015 11:54:29 AM, 10057
prlog.h, C:\comm-central\mozilla\nsprpub\pr\include, 6/4/2015 11:54:29 AM, 6890
primpl.h, C:\comm-central\mozilla\nsprpub\pr\include\private, 6/4/2015 11:54:29 AM, 74379
nspr.def, C:\comm-central\mozilla\nsprpub\pr\src, 6/4/2015 11:54:29 AM, 9440
prfile.c, C:\comm-central\mozilla\nsprpub\pr\src\io, 6/4/2015 11:54:29 AM, 19271
prlog.c, C:\comm-central\mozilla\nsprpub\pr\src\io, 6/4/2015 11:54:29 AM, 16462
prprf.c, C:\comm-central\mozilla\nsprpub\pr\src\io, 6/4/2015 11:54:29 AM, 25090
prsocket.c, C:\comm-central\mozilla\nsprpub\pr\src\io, 6/4/2015 11:54:29 AM, 45969
prlink.c, C:\comm-central\mozilla\nsprpub\pr\src\linking, 6/4/2015 11:54:29 AM, 45573
os2thred.c, C:\comm-central\mozilla\nsprpub\pr\src\md\os2, 6/4/2015 11:54:29 AM, 9200
unix.c, C:\comm-central\mozilla\nsprpub\pr\src\md\unix, 6/4/2015 11:54:29 AM, 106195
unixware.c, C:\comm-central\mozilla\nsprpub\pr\src\md\unix, 6/4/2015 11:54:29 AM, 12748
uxshm.c, C:\comm-central\mozilla\nsprpub\pr\src\md\unix, 6/4/2015 11:54:29 AM, 18632
uxwrap.c, C:\comm-central\mozilla\nsprpub\pr\src\md\unix, 6/4/2015 11:54:29 AM, 15194
ntmisc.c, C:\comm-central\mozilla\nsprpub\pr\src\md\windows, 6/4/2015 11:54:29 AM, 33140
ntsec.c, C:\comm-central\mozilla\nsprpub\pr\src\md\windows, 6/4/2015 11:54:29 AM, 7990
ntthread.c, C:\comm-central\mozilla\nsprpub\pr\src\md\windows, 6/4/2015 11:54:29 AM, 14545
w32shm.c, C:\comm-central\mozilla\nsprpub\pr\src\md\windows, 6/4/2015 11:54:29 AM, 10341
w95io.c, C:\comm-central\mozilla\nsprpub\pr\src\md\windows, 6/4/2015 11:54:29 AM, 36133
w95thred.c, C:\comm-central\mozilla\nsprpub\pr\src\md\windows, 6/4/2015 11:54:29 AM, 7739
prcountr.c, C:\comm-central\mozilla\nsprpub\pr\src\misc, 6/4/2015 11:54:29 AM, 11502
prinit.c, C:\comm-central\mozilla\nsprpub\pr\src\misc, 6/4/2015 11:54:29 AM, 21929
prtrace.c, C:\comm-central\mozilla\nsprpub\pr\src\misc, 6/4/2015 11:54:29 AM, 24455
ptio.c, C:\comm-central\mozilla\nsprpub\pr\src\pthreads, 6/4/2015 11:54:29 AM, 149632
ptthread.c, C:\comm-central\mozilla\nsprpub\pr\src\pthreads, 6/4/2015 11:54:29 AM, 53543
prcmon.c, C:\comm-central\mozilla\nsprpub\pr\src\threads, 6/4/2015 11:54:29 AM, 12085
prcthr.c, C:\comm-central\mozilla\nsprpub\pr\src\threads, 6/4/2015 11:54:29 AM, 11427
prucv.c, C:\comm-central\mozilla\nsprpub\pr\src\threads\combined, 6/4/2015 11:54:29 AM, 18755
prulock.c, C:\comm-central\mozilla\nsprpub\pr\src\threads\combined, 6/4/2015 11:54:29 AM, 12273
prustack.c, C:\comm-central\mozilla\nsprpub\pr\src\threads\combined, 6/4/2015 11:54:29 AM, 4408
pruthr.c, C:\comm-central\mozilla\nsprpub\pr\src\threads\combined, 6/4/2015 11:54:29 AM, 57096
anonfm.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 8057
instrumt.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 12412
logfile.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 1089
logger.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 3004
mbcs.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 5021
nameshm1.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 16903
ntioto.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 8228
op_excl.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 3324
randseed.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 3373
README.TXT, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 7320
y2k.c, C:\comm-central\mozilla\nsprpub\pr\tests, 6/4/2015 11:54:29 AM, 35372
nsInMemoryDataSource.cpp, C:\comm-central\mozilla\rdf\base, 6/4/2015 11:54:35 AM, 60524
nsRDFContentSink.cpp, C:\comm-central\mozilla\rdf\base, 6/4/2015 11:54:35 AM, 47796
nsRDFXMLDataSource.cpp, C:\comm-central\mozilla\rdf\base, 6/4/2015 11:54:35 AM, 35273
nsNSSIOLayer.cpp, C:\comm-central\mozilla\security\manager\ssl, 6/4/2015 11:54:35 AM, 82494
nsNTLMAuthModule.cpp, C:\comm-central\mozilla\security\manager\ssl, 6/4/2015 11:54:35 AM, 34028
nsSecureBrowserUIImpl.cpp, C:\comm-central\mozilla\security\manager\ssl, 6/4/2015 11:54:35 AM, 46283
SSLServerCertVerification.cpp, C:\comm-central\mozilla\security\manager\ssl, 6/4/2015 11:54:35 AM, 64526
TransportSecurityInfo.cpp, C:\comm-central\mozilla\security\manager\ssl, 6/4/2015 11:54:35 AM, 32625
bbenv-example.sh, C:\comm-central\mozilla\security\nss\automation\buildbot-slave, 6/4/2015 11:54:36 AM, 1440
httpserv.c, C:\comm-central\mozilla\security\nss\cmd\httpserv, 6/4/2015 11:54:37 AM, 37933
selfserv.c, C:\comm-central\mozilla\security\nss\cmd\selfserv, 6/4/2015 11:54:37 AM, 77367
certvfypkix.c, C:\comm-central\mozilla\security\nss\lib\certhigh, 6/4/2015 11:54:38 AM, 69901
ocsp.c, C:\comm-central\mozilla\security\nss\lib\certhigh, 6/4/2015 11:54:38 AM, 194247
pkix_build.c, C:\comm-central\mozilla\security\nss\lib\libpkix\pkix\top, 6/4/2015 11:54:38 AM, 152911
pkix_tools.c, C:\comm-central\mozilla\security\nss\lib\libpkix\pkix\util, 6/4/2015 11:54:38 AM, 51172
pkix_tools.h, C:\comm-central\mozilla\security\nss\lib\libpkix\pkix\util, 6/4/2015 11:54:38 AM, 47074
pkix_pl_lifecycle.c, C:\comm-central\mozilla\security\nss\lib\libpkix\pkix_pl_nss\system, 6/4/2015 11:54:39 AM, 9504
debug_module.c, C:\comm-central\mozilla\security\nss\lib\pk11wrap, 6/4/2015 11:54:39 AM, 86995
manifest.mn, C:\comm-central\mozilla\security\nss\lib\pk11wrap, 6/4/2015 11:54:39 AM, 1238
pk11load.c, C:\comm-central\mozilla\security\nss\lib\pk11wrap, 6/4/2015 11:54:39 AM, 17526
tdcache.c, C:\comm-central\mozilla\security\nss\lib\pki, 6/4/2015 11:54:39 AM, 28896
nssilckt.h, C:\comm-central\mozilla\security\nss\lib\util, 6/4/2015 11:54:39 AM, 6038
nssilock.c, C:\comm-central\mozilla\security\nss\lib\util, 6/4/2015 11:54:39 AM, 12000
nssilock.h, C:\comm-central\mozilla\security\nss\lib\util, 6/4/2015 11:54:39 AM, 8280
Makefile, C:\comm-central\mozilla\security\nss\tests\remote, 6/4/2015 11:54:39 AM, 7757
mozStorageStatement.cpp, C:\comm-central\mozilla\storage, 6/4/2015 11:54:43 AM, 25101
runtests.py, C:\comm-central\mozilla\testing\mochitest, 6/4/2015 11:54:53 AM, 99730
runtestsremote.py, C:\comm-central\mozilla\testing\mochitest, 6/4/2015 11:54:53 AM, 28736
device.py, C:\comm-central\mozilla\testing\mozbase\mozrunner\mozrunner\base, 6/4/2015 11:54:58 AM, 5900
ApplicationReputation.cpp, C:\comm-central\mozilla\toolkit\components\downloads, 6/4/2015 11:55:19 AM, 38929
ApplicationReputation.h, C:\comm-central\mozilla\toolkit\components\downloads, 6/4/2015 11:55:19 AM, 1621
Classifier.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 19913
HashStore.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 30654
LookupCache.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 17996
nsUrlClassifierDBService.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 47985
nsUrlClassifierPrefixSet.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 12402
nsUrlClassifierStreamUpdater.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 19511
ProtocolParser.cpp, C:\comm-central\mozilla\toolkit\components\url-classifier, 6/4/2015 11:55:22 AM, 19221
leak-gauge.html, C:\comm-central\mozilla\tools\leak-gauge, 6/4/2015 11:55:38 AM, 11530
leak-gauge.pl, C:\comm-central\mozilla\tools\leak-gauge, 6/4/2015 11:55:38 AM, 9319
nsDocLoader.cpp, C:\comm-central\mozilla\uriloader\base, 6/4/2015 11:55:39 AM, 46837
nsExternalHelperAppService.h, C:\comm-central\mozilla\uriloader\exthandler, 6/4/2015 11:55:39 AM, 17518
nsOfflineCacheUpdate.cpp, C:\comm-central\mozilla\uriloader\prefetch, 6/4/2015 11:55:39 AM, 75277
nsOfflineCacheUpdateService.cpp, C:\comm-central\mozilla\uriloader\prefetch, 6/4/2015 11:55:39 AM, 24799
nsPrefetchService.cpp, C:\comm-central\mozilla\uriloader\prefetch, 6/4/2015 11:55:39 AM, 25160
OfflineCacheUpdateChild.cpp, C:\comm-central\mozilla\uriloader\prefetch, 6/4/2015 11:55:39 AM, 15972
OfflineCacheUpdateGlue.cpp, C:\comm-central\mozilla\uriloader\prefetch, 6/4/2015 11:55:39 AM, 7058
OfflineCacheUpdateParent.cpp, C:\comm-central\mozilla\uriloader\prefetch, 6/4/2015 11:55:39 AM, 7584
GonkNativeWindowClientICS.cpp, C:\comm-central\mozilla\widget\gonk\nativewindow, 6/4/2015 11:55:39 AM, 13348
GonkNativeWindowICS.cpp, C:\comm-central\mozilla\widget\gonk\nativewindow, 6/4/2015 11:55:39 AM, 21423
nsDeviceContextSpecG.cpp, C:\comm-central\mozilla\widget\gtk, 6/4/2015 11:55:39 AM, 22158
nsWindow.h, C:\comm-central\mozilla\widget\qt, 6/4/2015 11:55:40 AM, 11345
test_keycodes.xul, C:\comm-central\mozilla\widget\tests, 6/4/2015 11:55:40 AM, 238477
nsdefs.h, C:\comm-central\mozilla\widget\windows, 6/4/2015 11:55:40 AM, 1405
nsDebugImpl.cpp, C:\comm-central\mozilla\xpcom\base, 6/4/2015 11:55:40 AM, 15366
nsComponentManager.cpp, C:\comm-central\mozilla\xpcom\components, 6/4/2015 11:55:40 AM, 62777
nsObserverService.cpp, C:\comm-central\mozilla\xpcom\ds, 6/4/2015 11:55:40 AM, 10729
TimeStamp_windows.cpp, C:\comm-central\mozilla\xpcom\ds, 6/4/2015 11:55:40 AM, 17429
Logging.h, C:\comm-central\mozilla\xpcom\glue, 6/4/2015 11:55:40 AM, 2100
nsPipe3.cpp, C:\comm-central\mozilla\xpcom\io, 6/4/2015 11:55:41 AM, 50756
nsStorageStream.cpp, C:\comm-central\mozilla\xpcom\io, 6/4/2015 11:55:41 AM, 16881

Comment 20

2 years ago
Well, the stuff in the mozilla folder is the M-C repository, this should be taken care of by Gecko.

As for changing the C-C stuff, bug 1165515 comment #1 and further down gives instructions.
Until we have fixed it for real, just undoing this part of <https://bug1165515.bugzilla.mozilla.org/attachment.cgi?id=8613641> should get you build again (it did for SeaMonkey at least):

--- a/xpcom/glue/Logging.h
+++ b/xpcom/glue/Logging.h
@@ -58,10 +58,13 @@ inline bool log_test(const PRLogModuleIn

 #define MOZ_LOG(_module,_level,_args)     \
   PR_BEGIN_MACRO             \
     if (MOZ_LOG_TEST(_module,_level)) { \
       PR_LogPrint _args;         \
     }                     \
   PR_END_MACRO

+#undef PR_LOG
+#undef PR_LOG_TEST
+
 #endif // mozilla_logging_h
Component: General → Backend
Product: Thunderbird → MailNews Core
(Assignee)

Updated

2 years ago
Assignee: nobody → ewong

Comment 22

2 years ago
(In reply to Jorg K from comment #18)
> After replacing PR_LOG to MOZ_LOG this is the next error:
> 
> h:/mozilla-source/comm-central/mailnews/local/src/nsPop3Sink.cpp(63) :
> error C2664: 'bool mozilla::detail::log_test(const PRLogModuleInfo
> *,mozilla::LogLevel)' : cannot convert argument 2 from 'PRLogModuleLevel' to
> 'mozilla::LogLevel'
> Conversion to enumeration type requires an explicit cast (static_cast,
> C-style cast or function-style cast)

Log levels are now a C++ enum

This sort if bug is best addressed by PERL / grep / sed / awk

Comment 23

2 years ago
(In reply to Philip Chee from comment #22)
> This sort if bug is best addressed by PERL / grep / sed / awk

Yes, and the instructions are here: bug 1165515 comment #1 (and further comments in that bug).

BTW, the workaround from comment #21 works in Thunderbird as well.
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 24

2 years ago
Created attachment 8615919 [details] [diff] [review]
proposed patch (v1)
Attachment #8615919 - Flags: review?(rkent)

Comment 25

2 years ago
Good job, thanks!

Comment 26

2 years ago
I looked through the whole lot. In nsMsgBiffManager.cpp you have the include twice.

Comment 27

2 years ago
(In reply to Jorg K from comment #26)
> I looked through the whole lot. In nsMsgBiffManager.cpp you have the include
> twice.

Feel free to give a feedback+ on the patch if you think it is correct. That can help speed a review with a second opinion.

Comment 28

2 years ago
Comment on attachment 8615919 [details] [diff] [review]
proposed patch (v1)

As I said, one doubled-up include of Logging.h should be removed.
I'm not sure about the use of "using namespace mozilla;"
Sometimes it's used, sometimes it's not, once it was even removed.
Otherwise the patch is fine.
Attachment #8615919 - Flags: feedback+

Comment 29

2 years ago
Created attachment 8616113 [details] [diff] [review]
Patch to merge into Ewong's patch 8615919: proposed patch (v1)

Comment 30

2 years ago
Created attachment 8616115 [details] [diff] [review]
Fix for bug 1171323 regression

This patch fixes a new issue introduced by bug 1171323, but the mailnews will not compile with current mozilla-central without this.
Attachment #8616115 - Flags: review?(Pidgeot18)

Comment 31

2 years ago
Comment on attachment 8615919 [details] [diff] [review]
proposed patch (v1)

Looks good with some nits. The big changes are defining namespace mozilla in a few files where the usage of MOZ_LOG is large.

See my new patch that should be merged into this one to get the final result. r+ with that merge.
Attachment #8615919 - Flags: review?(rkent) → review+
Comment on attachment 8616115 [details] [diff] [review]
Fix for bug 1171323 regression

Review of attachment 8616115 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8616115 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 33

2 years ago
(In reply to Kent James (:rkent) from comment #31)
> Comment on attachment 8615919 [details] [diff] [review]
> proposed patch (v1)
> 
> Looks good with some nits. The big changes are defining namespace mozilla in
> a few files where the usage of MOZ_LOG is large.
> 
> See my new patch that should be merged into this one to get the final
> result. r+ with that merge.

pardon my confusion here.

When do we do this?

   #include "mozilla/Logging.h"

  using namespace mozilla;

   ...  MOZ_LOG(foo, LogLevel::Info, bar);

And when do we do this?

   #include "mozilla/Logging.h"

    ...  MOZ_LOG(foo, mozilla::LogLevel::Info, bar);

Going through my patch, I've noticed that the ldap/ code uses the latter
and the mailnews/ code uses the former.

Looking at comment 31, when "MOZ_LOG" is large.   Wouldn't it be more
consistent to use one way instead of having two different ways sprinkled
all over the code?
(Assignee)

Comment 34

2 years ago
Created attachment 8616317 [details] [diff] [review]
proposed patch (v3)

I have combined both v1 of my proposed patch and the patch from :rkent plus
a few changes to the LDAP code (s/mozilla::LogLevel/LogLevel).
Attachment #8615919 - Attachment is obsolete: true
Attachment #8616113 - Attachment is obsolete: true
(Assignee)

Comment 35

2 years ago
Comment on attachment 8616317 [details] [diff] [review]
proposed patch (v3)

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/4531fe7c34da
Attachment #8616317 - Flags: review+
(Assignee)

Comment 36

2 years ago
Comment on attachment 8616115 [details] [diff] [review]
Fix for bug 1171323 regression

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/724e8467d630

Comment 37

2 years ago
Sorry for the confusion here. We were really tied up getting the buildbot fixes in so that we could release Thunderbird 38, and I neglected to mention my checkins. I rush on blockers to get them pushed, and you were offline at the time.

I think this is done, right?

Concerning comment 33, there is no set method here. I discussed this briefly with jcranmer in IRC, he is happy to add "using namespace mozilla" anywhere within mailnews code. I was a little more conservative, leaving things as you did them whenever possible, except for a couple of cases where there were lots of MOZ_LOG entries and you had not included the namespace, so I added it to reduce the number of overlength lines.

But in general, if namespace mozilla is defined, then we should rely on it, and not add mozilla:: prefixes.

As for LDAP, IMHO it really doesn't matter either way what we do.
(Assignee)

Comment 38

2 years ago
Looks like it's done.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-thunderbird41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.