1171671 - Simplify Boot Animation control

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Sotaro Ikeda [:sotaro]]

StartBootAnimation() and StopBootAnimation() is called from GonkDispaly. Especially StopBootAnimation() is called from many places. It seems better to simplify it.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify Boot Animation control

Comment 2

[Sotaro Ikeda [:sotaro]]

Current GonkDisplay calls StartBootAnimation() from many places. But They are not necessary if we want to stop BootAnimation at the same timing to current implementation.

Comment 3

[Sotaro Ikeda [:sotaro]]

It seems better to extend boot animation duration as in Bug 1165200 Comment 18 in a different bug.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify Boot Animation control

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify Boot Animation control

Add missed change.

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 8615583 [details] [diff] [review]
patch - Simplify Boot Animation control

Review of attachment 8615583 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. This makes more sense.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: diagram of GonkDisplayJB

After bug 1138287 and Bug 1171671 are fixed, module relationship of GonkDisplayJB becomes like this diagram.

Comment 8

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dc8eb31a23b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9dc8eb31a23b

Comment 10

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Simplify Boot Animation control. (b2g v2.2)

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 1191674
User impact if declined:
User will see the bootAnim pause for a long times.
Testing completed:
The are already at m-c.
Risk to taking this patch (and alternatives if risky):
low
String or UUID changes made by this patch:
no

Comment 11

[Wesly Huang (EPM)]

TAM's comment for this issue: 

This is one of the three dependent issues of bug 1191674, which is needed by partner TCL for their product based on 2.2. Thought this is not functional critical however indeed impact first time user experience (power on animation is the first thing user will see), plus the risk is low so I think it's worth fixing. In comment 38 of bug 1191674 we can already see those patches work for their problem.

Hi Josh: 

how is your view about landing it on 2.2

Comment 12

[Josh Cheng [:josh]]

Hi Wesly,
We currently do not have plan for shipping device on 2.2 but 2.2r.
I like to make this 2.2r+. Thanks!

Comment 13

[Josh Cheng [:josh]]

Comment on attachment 8647273 [details] [diff] [review]
Simplify Boot Animation control. (b2g v2.2)

Thanks Jerry,
Make this blocking-b2g: 2.2r+.
Currently no 2.2r approval required.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/398cecb9af80