1191674 - the boot animation has a unnecessary pause times

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[cuizhangbo]

This is witnessed on a Alcatel OneTouch Fire E. the boot animation has a unnecessary pause times；

Alcatel Pixi screen
Animated Firefox OS screen（At the end of the animation there will be a pause of about 10s）
Black screen
Another static Firefox OS screen
Lock screen

Aim of this bug is to investigate why it has a unnecessary pause times and how to eliminating the pause times.

Comment 1

[cuizhangbo]

Please help with this problem.
I think this bug is similar to Bug 1130300.

Comment 2

[cuizhangbo]

This bug is appear in Firefox os 2.2, Firefox os 2.0 is ok.

Comment 3

[Wesly Huang (EPM)]

Hi ZhangBo:

I think the symptom of 1130300 is fixed in 2.2 by bug 1156141 already, would you help check if you have its patch in your code base? And if this is reproducible in Flame? Thanks.

Comment 4

[cuizhangbo]

Hi Wesly,

My code base has the patch,and this problem is reproducible, so the patch is not solve this problem.
This problem is also reproducible in Flame

Comment 5

[Wesly Huang (EPM)]

Hi ZhangBo:

I assume your main concern is the so called "10s" black between the "animated Firefox OS" and the "static Firefox OS", right?

Hi Norry:

Would you help check if you can also see this in Flame 2.2 and master? Thanks!

Comment 6

[cuizhangbo]

Hi Wesly,

It is not a black screen but the last frame of animation between the "animated Firefox OS" and the "static Firefox OS"

Comment 7

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi cuizhangbo,

What's your gecko version and the git commit id with your test?
The bug 1165161 keeps the boot animation running until the system is almost ready. It's on m-c, so you can check the flame with m-c to see the result.

Comment 8

[cuizhangbo]

Hi Wesly，
I download the mirror from ftp (http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-b2g37_v2_2-flame-kk-eng/), the mirror is released in 09-Aug-2015. then load them and push bootanimation.zip to /system/media/. The problem is exist.

what is m-c?

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

m-c => hg mozilla-central branch(git master branch)

How about the last flame-kk image[1]?

[1]
http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central-flame-kk-eng/

Comment 10

[cuizhangbo]

Hi Jerry,
The last flame-kk image[1] is OK. 
What is the difference between the two versions about this problem？ please give me the patch.

thanks.

Comment 11

[Wesly Huang (EPM)]

ni for comment#5

per above comments seems works on m-c but not 2.2?

(In reply to Wesly Huang from comment #5)
> Hi ZhangBo:
> 
> I assume your main concern is the so called "10s" black between the
> "animated Firefox OS" and the "static Firefox OS", right?
> 
> Hi Norry:
> 
> Would you help check if you can also see this in Flame 2.2 and master?
> Thanks!

Comment 12

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Bug 1165161 and its dependent bugs should fix this issue. They base on master branch. I think you can't apply them directly for v2.2 branch.

Comment 13

[Norry.L.F(Leave from Mozilla)]

Sorry for late reply

I can repro this bug on Flame 2.2 and master.

Actual result: the unnecessary pause times(between screen with red words and screen with firefox animation) will appear for 14 seconds(you can see 00:25~00:39)

See attachment: FlameKK_v2.5.3gp and logcat_v2.5.txt

Device: Flame KK v2.2(Affected)
Gaia-Rev        f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0c7a85251e10
Build-ID        20150805032505
Version         37.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150805.065842
FW-Date         Wed Aug  5 06:58:54 EDT 2015
Firmware Version       v18D v4
Bootloader      L1TC000118D0

Device: Flame KK v2.5(Affected)
Gaia-Rev        3e5271663e7ef26290c29a45d2e42c0d3c20fe04
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/fd69d51a4068
Build-ID        20150809150206
Version         42.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150809.182413
FW-Date         Sun Aug  9 18:24:24 EDT 2015
Firmware Version       v18D v4
Bootloader      L1TC000118D0

Comment 14

[Norry.L.F(Leave from Mozilla)]

Attachment: logcat_v2.5.txt

Comment 15

[Norry.L.F(Leave from Mozilla)]

Attachment: FlameKK_v2.5.3gp

Comment 16

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Norry,
Your device doesn't have bootanimation.zip. Please check comment 8.
The bootanimation.zip is at B2G/gonk-misc .

Comment 17

[cuizhangbo]

Hi Jerry,
please give me a patch for v2.2 branch. 

Thanks!

Comment 18

[cuizhangbo]

Hi Jerry,

The patch can't be applied for v2.2 branch.

Comment 19

[Wesly Huang (EPM)]

Hi Zhangbo:

Before proceed further, would you help me understand what's the target product for this issue? I think there should be no further activity for fire E, right?

Comment 20

[cuizhangbo]

Hi Wesly,

It's go-flip.

Comment 21

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Norry,

Please use this commend to check whether the device has the boot anim zip file.

adb shell ls /system/media

You should see a file as:
bootanimation.zip

Thanks.

Comment 22

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: bootanimation.zip

The bootanim zip file.

The anim size might not correct, but you still can see the anim.

Comment 23

[Jerry Shih[:jerry] (UTC+8) (inactive)]

push the zip file to device:

adb shell remount
adb shell mkdir /system/media
adb push bootanimation.zip /system/media/bootanimation.zip

Comment 24

[Wesly Huang (EPM)]

Have quick discussion w/ Jerry and current discussion seems a little mixed. Let's clarify again before next step:

A. Mozilla's 2.2 and m-c status, of power on display (test in comment#13 may be lack of proper animation resource file included)
B. TCL's 2.2 status of power on display (may not be the same as A)

So we need:

For A: in comment#21~23 Jerry has provided a way to check if animation file is properly included in test, also attach the animation file in case Norry will need it for test. Please Norry help check, if no animation in previous test then include it to test again. Thank you.

For B: Zhangbo would you also provide a video of Flame you see so we confirm we have same test result? Thank you.

Comment 25

[Norry.L.F(Leave from Mozilla)]

Attachment: FlameKK_v2.2&2.5.3gp

Sorry for my misunderstanding, below is my retest result.

With Jerry's bootanimation.zip, on flameKK v2.2 I can repro this bug that the animation will pause for about 11 seconds(please see 00:30~00:41). While on master, the animation will be running until system is almost ready.

Please check video: FlameKK_v2.2&2.5.3gp

Device: Flame KK 2.2(Affected)
Build ID               20150810032504
Gaia Revision          102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gaia Date              2015-08-06 20:46:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/da29b5af4232
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150810.065425
Firmware Date          Mon Aug 10 06:54:37 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5(Unaffected)
Build ID               20150810150206
Gaia Revision          9a8880a95ee4a4aea7895d4e2bcab31bc49ea281
Gaia Date              2015-08-10 16:01:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8cba870a352c
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150810.183734
Firmware Date          Mon Aug 10 18:37:46 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 26

[Norry.L.F(Leave from Mozilla)]

Attachment: FlameKK_v2.2&2.5.3gp

Sorry for my misunderstanding, below is my retest result.

With Jerry's bootanimation.zip, on flameKK v2.2 I can repro this bug that the animation will pause for about 11 seconds(please see 00:30~00:41). While on master, the animation will be running until system is almost ready.

Please check video: FlameKK_v2.2&2.5.3gp

Device: Flame KK 2.2(Affected)
Build ID               20150810032504
Gaia Revision          102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gaia Date              2015-08-06 20:46:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/da29b5af4232
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150810.065425
Firmware Date          Mon Aug 10 06:54:37 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5(Unaffected)
Build ID               20150810150206
Gaia Revision          9a8880a95ee4a4aea7895d4e2bcab31bc49ea281
Gaia Date              2015-08-10 16:01:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8cba870a352c
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150810.183734
Firmware Date          Mon Aug 10 18:37:46 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 27

[Norry.L.F(Leave from Mozilla)]

Leaving qawanted for zhangbo's result

Comment 28

[cuizhangbo]

Attachment: v2.2.mp4

v2.2

Comment 29

[cuizhangbo]

Attachment: v2.5.mp4

v2.5

Comment 30

[Wesly Huang (EPM)]

Thanks Norry and Zhangbo, per your video in comment#25~29 we are aligned about the observation for 2.2 and 2.5's power on behavior.

@Jerry, I think the result match your expectation as discussed yesterday, right? Do you think it's feasible to put a fix on 2.2 so it behaves like 2.5? Thanks!

Comment 31

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: fix GonkDisplay::QueueBuffer() for bootAnim. v2.2

uplift Bug 1165200 to v2.2

Comment 32

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: simplify boot animation control. v2.2

uplift Bug 1171671 to v2.2

Comment 33

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: stop bootAnim with "browser-ui-startup-complete" event. v2.2

uplift Bug 1165161 to v2.2

Comment 34

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Michael,

These patches try to extend the bootAnim as master does for v2.2.

Comment 35

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi cuizhangbo,

Please try to build your gecko with the attachment 8646779 [details] [diff] [review], 8646784 and 8646784.

Comment 36

[Wesly Huang (EPM)]

Thanks Jerry for the prompt patch!

@Zhangbo:

would you help have a test in parallel, to see if those patches work for your case? Thanks.

Comment 37

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Zhangbo,
Could you please check whether these patches work.
Then I will request v2.2 approval for these patches.

Comment 38

[cuizhangbo]

Hi Jerry,

Yes,those patches can solve this issue.

Thanks.

Comment 39

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Wesly,
Please check the dependent bug's approval request.

Comment 40

[Wesly Huang (EPM)]

Thanks Jerry, I've put comment in those 3 bugs for partner's status, and asked for RM's approval. (also explained the background to RM in person)

Comment 41

[Jerry Shih[:jerry] (UTC+8) (inactive)]

The patch in bug 1165200, 1171671, 1165161 are all at v2.2r now.