1171825 - [v2.2] Cannot import name TreeherderRequest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Mike Lien[:mlien]]

v2.1 and v2.2 cannot run gaia-ui-test due to import error
below are v2.1 error message:

+ cp /var/lib/jenkins/JenkinsCI/B2G_Resource/GaiaUITest/manifest_flame_v2dot1_dialer.ini /var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/manifest.ini
+ cp /var/lib/jenkins/JenkinsCI/B2G_Resource/GaiaUITest/manifest_flame_v2dot1_settings.ini /var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/manifest.ini
+ gaiatest --address=localhost:2834 --testvars=/var/lib/jenkins/JenkinsCI/B2G_Resource/GaiaUITest/gaiatestvars_flame_v2dot1.json --xml-output=results/result.xml --html-output=results/index.html --restart --timeout=30000 --type=b2g+smoketest gaiatest/tests/functional/manifest.ini
Traceback (most recent call last):
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/bin/gaiatest", line 9, in <module>
    load_entry_point('gaiatest-v2.1==0.1', 'console_scripts', 'gaiatest')()
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/pkg_resources.py", line 337, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/pkg_resources.py", line 2279, in load_entry_point
    return ep.load()
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/pkg_resources.py", line 1989, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/__init__.py", line 6, in <module>
    from mixins import *
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/mixins/__init__.py", line 6, in <module>
    from treeherder import TreeherderOptionsMixin, \
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/mixins/treeherder.py", line 19, in <module>
    from thclient import TreeherderRequest, TreeherderJobCollection
ImportError: cannot import name TreeherderRequest

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The solution is to pin the treeherder client as we did recently in master:
https://github.com/mozilla-b2g/gaia/commit/1ca290208510ba80c9ed08591d4af682ecf2ba38

Comment 2

[Lance（leave from Mozilla）]

Hi Martijn,
I have run it, and it still passes(10/10). Could you please review this patch. Thanks!

[Gaia]v2.2: https://github.com/Lance-k/patch/commit/30da479c8e1dc18e20a6136b56bfa67b9e8c8e1a

Comment 3

[Martijn Wargers (dead)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/30472

Here is the v2.2 pull request for it. I'll merge it when Treeherder for it is green.

Comment 4

[Martijn Wargers (dead)]

Oh, William is also asking for v2.1 and v2.1s versions in bug 1166873, comment 15. I'll do that.

Comment 5

[Martijn Wargers (dead)]

Attachment: v2.1 pull request

Comment 6

[Martijn Wargers (dead)]

Attachment: v2.1s pull request

Comment 7

[Martijn Wargers (dead)]

Oh, I guess v2.1 and v2.1s don't have Treeherder Try support.
William, I can check in the v2.1, v2.1s and v2.2 pull requests if they look good to you.

Comment 8

[William Hsu [:whsu]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #7)
> Oh, I guess v2.1 and v2.1s don't have Treeherder Try support.
> William, I can check in the v2.1, v2.1s and v2.2 pull requests if they look
> good to you.

Please help us uplift patch to v2.1 and v2.1s branch because we encountered the same ERROR on these branches.
Thank you Martijn.

@ v2.1 branch
+ gaiatest --address=localhost:2834 --testvars=/var/lib/jenkins/JenkinsCI/B2G_Resource/gaiatestvars_flame_v2dot1.json --xml-output=results/result.xml --html-output=results/index.html --restart --timeout=30000 --type=b2g+smoketest gaiatest/tests/functional/manifest.ini
Traceback (most recent call last):
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/bin/gaiatest", line 9, in <module>
    load_entry_point('gaiatest-v2.1==0.1', 'console_scripts', 'gaiatest')()
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/pkg_resources.py", line 337, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/pkg_resources.py", line 2279, in load_entry_point
    return ep.load()
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/pkg_resources.py", line 1989, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/__init__.py", line 6, in <module>
    from mixins import *
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/mixins/__init__.py", line 6, in <module>
    from treeherder import TreeherderOptionsMixin, \
  File "/var/lib/jenkins/JenkinsCI/B2G_Flame_2dot1_Kitkat/B2G_Gaia_2dot1/tests/python/gaia-ui-tests/gaiatest/mixins/treeherder.py", line 19, in <module>
    from thclient import TreeherderRequest, TreeherderJobCollection
ImportError: cannot import name TreeherderRequest

Comment 9

[Martijn Wargers (dead)]

Ok, that sounds like an approval to me.
Merged v2.2: https://github.com/mozilla-b2g/gaia/commit/8f3d9b5d17eb738f1739c993d768d3288dcde3ae
Merged v2.1: https://github.com/mozilla-b2g/gaia/commit/f8b848c82d1ed589f7a1eb5cc099830c867ff1d4
Merged v2.1s: https://github.com/mozilla-b2g/gaia/commit/90463896d22b564fdd3202a97ff941e6cdc502ae

Comment 10

[Ryan VanderMeulen [:RyanVM]]

For future reference, v2.1 is merged to v2.1s, so you don't need to double-land. This is covered on the B2G Landing page.
https://wiki.mozilla.org/Release_Management/B2G_Landing#v2.1S

Comment 11

[Martijn Wargers (dead)]

Thanks for the heads-up, Ryan.

Comment 12

[William Hsu [:whsu]]

Thank you Martijn and Ryan.
Gaia UI test is back. :)