1171863 - Refresh the animation panel timelines when the panel is resized

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

STR:
- with bug 1155663 in open a page with animations
- open the animation inspector
- make sure animations are displayed
- resize the sidebar panel

ER: the timelines adapt on resize
AR: they don't!

Comment 1

[Patrick Brosset <:pbro>]

Working on this as part of 1197100. Turns out that removing all sizes in pixels and defining everything in % wasn't hard at all, so I'm going to do that.
The trick for the js-generated background and header is to have its size in % too, and have a debounced window resize handler that regenerates it.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug_1171863_-_Define_all_positions_and_sizes_in_pe.diff

Code should be OK, but I need to fix the broken tests now (16 failures). These are expected because various tests expect positions to be in pixels.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: liquid-timeline.gif

Here's a what the UI looks like now with the patch applied.

Comment 4

[Patrick Brosset <:pbro>]

Attachment: Bug_1171863_-_Define_all_positions_and_sizes_in_pe.diff

And here's the final patch, with the impacted tests fixed.

Comment 5

[Patrick Brosset <:pbro>]

Attachment: Bug_1171863_-_Define_all_positions_and_sizes_in_pe.diff

Forgot to remove an unrelated change.

Comment 6

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59c824f7ca25

Comment 7

[Tom Tromey :tromey]

Comment on attachment 8692166 [details] [diff] [review]
Bug_1171863_-_Define_all_positions_and_sizes_in_pe.diff

Review of attachment 8692166 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d821c903bd2b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for frequent failures in browser_animation_timeline_pause_button.js https://treeherder.mozilla.org/logviewer.html#?job_id=6006836&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/1968000b4c04

Comment 10

[Patrick Brosset <:pbro>]

Damn, sorry about that, and thanks for backing out. I have a fix for this test. Will take it for a spin on try shortly.

Comment 11

[Patrick Brosset <:pbro>]

The fix I made for the test seems to be working fine on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d49b95e49aa

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5210512b24b6

Comment 13

[Patrick Brosset <:pbro>]

Landed again with my test fix. Let's see if that stick. Given the many retriggers I did on try, it should.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5210512b24b6