Closed Bug 1171944 Opened 9 years ago Closed 4 years ago

Use color filters to replace multiple drawable resources with single gray scale image

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

35 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: Margaret, Unassigned, NeedInfo)

References

Details

We should audit the images in the tree to see if we can use color filters to eliminate some images that are included in multiple color.

On quick glance, I see a few candidates:

* lock_identified/lock_verified
* menu/menu_light/menu_pb
* reader/reader_active
* search_icon_active/search_icon_inactive
* sync_desktop/sync_desktop_inactive
* sync_mobile/sync_mobile_inactive

Martyn and Mike, do I remember things correctly that you two were talking about looking into this?

Looking through our drawable resources, I also see a ton of various "x" and "+" icons in different shapes and sizes. I wonder if we could find a way to consolidate those (but that would be a separate bug).
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(mhaigh)
(In reply to :Margaret Leibovic from comment #0)
> Martyn and Mike, do I remember things correctly that you two were talking
> about looking into this?

I filed bug 1167446 for magnifying glasses.

You could use the android:tint attribute to do a straight color replacement (which likely will only work for "flat" images) and perhaps combine it with android:tintMode to do more complex replacement (e.g. maybe this will act more like a color filter to do more complex replacement). Then there is also ImageView.setColorFilter.

> Looking through our drawable resources, I also see a ton of various "x" and
> "+" icons in different shapes and sizes. I wonder if we could find a way to
> consolidate those (but that would be a separate bug).

We said scaling down is okay so that's also feasible.
Flags: needinfo?(michael.l.comella)
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.