1171950 - Make sure the send button always trigger when it slides away with the keyboard

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please see bug 1171387. If the user tap the button with a certain timing, according to Julien it's possible we ended up not trigger the actual send action because the button have slide away with the keyboard.

If the patch of this test involves binding to different event, the test code should update too.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Here is the sequence of events we receive when we tap on send button on current master:

I/Messages( 1543): Content JS LOG: Send button   : touchstart 
I/Messages( 1543): Content JS LOG: Send button   : touchend 
I/Messages( 1543): Content JS LOG: Send button   : mousedown 
I/Messages( 1543): Content JS LOG: Message Input : blur 
I/Messages( 1543): Content JS LOG: Send button   : mouseup 
I/Messages( 1543): Content JS LOG: Send button   : click 

Binding to "touchsart/touchend" doesn't seem to be a good idea, since user can tap and then move finger to somewhere else to cancel action if user has changed his mind.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The complete sequence on Flame is, no matter how fast I tried to move my finger:

touchstart
touchend
mousedown
blur (of the input)
focus (of the button)
mouseup
click
resize (of the window)

whereas the event generated by Marionette tap and the touch shim of B2G Desktop is

touchstart
touchend
mousedown
blur (of the input)
focus (of the button)
resize (of the window)
mouseup

with click event missing.

I still don't believe it's possible to reproduce that on the phone. Maybe this can be reproduced on faster hardware?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Just a thought: it might be actually depend on the inproc/oop of the Message app; the resize event is (eventually) triggered by System app resizing the frame and sliding the keyboard away. Not sure how asyncMessage works between inproc *threads*; we might be blocking the mouseup event in the Message app *with* the resizing operation in the System app.

Inserting more dump() into System app and IM API might answer this. If this only happens in inproc Message app, I don't think it's worth fixing at all.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is no longer a valid bug with bug 1176926 in place. I am going to back out bug 1171387 and bug 1174062 to remove all reference to this bug.