1172201 - Correct GradleDynamicVersion lint warning

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Nick, what should we do here? Should we suppress the warning?

From Android Lint:

GradleDynamicVersion: Gradle Dynamic Version
../../build.gradle:50: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:support-v4:22.+)

  47 }
  48 
  49 dependencies {
  50     compile 'com.android.support:support-v4:22.+'
  51 
  52     if (mozconfig.substs.MOZ_NATIVE_DEVICES) {

Note: This issue has an associated quickfix operation in Android Studio/IntelliJ Fix
Priority: 4 / 10
Category: Correctness
Severity: Warning
Explanation: Gradle Dynamic Version.
Using + in dependencies lets you automatically pick up the latest available version rather than a specific, named version. However, this is not recommended; your builds are not repeatable; you may have tested with a slightly different version than what the build server used. (Using a dynamic version as the major version number is more problematic than using it in the minor version position.)

More info:

To suppress this error, use the issue id "GradleDynamicVersion" as explained in the Suppressing Warnings and Errors section.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #0)
> Nick, what should we do here? Should we suppress the warning?

Nah, this was just laziness and uncertainty on my part.

> From Android Lint:
> 
> GradleDynamicVersion: Gradle Dynamic Version
> ../../build.gradle:50: Avoid using + in version numbers; can lead to
> unpredictable and unrepeatable builds (com.android.support:support-v4:22.+)
> 
>   47 }
>   48 
>   49 dependencies {
>   50     compile 'com.android.support:support-v4:22.+'

Just pin this to whatever version we use -- 22.0.1, I think.

Comment 2

[Nick Alexander :nalexander [he/him]]

mcomella: No need for review.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/a733c1ca6e55

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a733c1ca6e55