1172347 - Homescreen search widget not usable with physical keyboard

Status: RESOLVED DUPLICATE of bug 1158906

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Jethro Beekman]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150511103818

Steps to reproduce:

I'm using Firefox for Android 38.0.5 on a Samsung Galaxy S Relay 4G with Android 4.1.2. I have added the "Firefox Search" widget to my homescreen. 

1. Slide open the physical keyboard. 
2. Press the search section of the "Firefox Search" widget.
3. Type some search query.
4. Press enter.


Actual results:

Nothing happens (except the search suggestions disappear).



Expected results:

The search should have activate with the typed-in query, as if the "search" button on the software keyboard had been pressed. I have not found another key or on-screen button that would activate the search.

Comment 1

[:Margaret Leibovic]

Is this a new problem that started when you updated to Firefox 38?

Comment 2

[Jethro Beekman]

I don't know, I used to use the standard Google search bar until I found out there was a Firefox one.

Comment 3

[:Margaret Leibovic]

kbrosnan, do we have one of these devices somewhere? Is there one in SF?

Comment 4

[Jethro Beekman]

I need to be at Google SF tomorrow, I could drop one off at Mozilla while I'm there for testing. I'll need it back at some point.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

I can confirm that this is reproducible with a Nexus 9 and the keyboard folio. I'll try to fix that.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

I would suggest a Bluetooth keyboard. There are not many devices any more with a physical keyboard.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

This has already been fixed in bug 1158906:
http://hg.mozilla.org/mozilla-central/rev/3f2af35fb884

And I can confirm that this bug is only reproducible with Firefox 38.0 and Beta (39.0) with my Nexus 9. The enter key is working with my own Fennec and Nightly builds.

@Jethro: Can you confirm that this is fixed on your phone too - using a Nightly build[1]?

[1]: https://nightly.mozilla.org/ or direct download: https://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-api-11/fennec-41.0a1.multi.android-arm.apk

Comment 8

[Jethro Beekman]

Seems to work, thanks for the fix.

However, sometimes if I type and press enter really fast, the query goes through and might come back, but then the search suggestions list pops up over the results.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Jethro Beekman from comment #8)
> Seems to work, thanks for the fix.

Thank your for testing!

> However, sometimes if I type and press enter really fast, the query goes
> through and might come back, but then the search suggestions list pops up
> over the results.

That's interesting. I tried to reproduce this but couldn't. Maybe it depends on how fast we can load the suggestions? Can you open another bug for this? Maybe attach a screenshot if possible.


@mfinkle: With "tracking-fennec: 38+" flag set, do we need to uplift the patch or can I close this bug as duplicate of bug 1158906?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Sebastian Kaspari from comment #9)

> @mfinkle: With "tracking-fennec: 38+" flag set, do we need to uplift the
> patch or can I close this bug as duplicate of bug 1158906?

I'll dupe this bug to bug 1158906 and request uplift to 39, if possible.

Comment 11

[Jethro Beekman]

> That's interesting. I tried to reproduce this but couldn't. Maybe it depends on 
> how fast we can load the suggestions? Can you open another bug for this? Maybe 
> attach a screenshot if possible.

https://bugzilla.mozilla.org/show_bug.cgi?id=1176418