1172457 - Settings page head title should be changed

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P5)

Description

[Atique Ahmed Ziad [:atiqueahmedziad]]

Attachment: bug.jpg

Go to- https://marketplace-dev.allizom.org/settings
See the head title, it's written "Account Settings | Firefox Marketplace"

But the Page title is Settings and also the URL is also "/settings" 

So, the head title should be written as "Settings | Firefox Marketplace"

Comment 1

[Atique Ahmed Ziad [:atiqueahmedziad]]

Hi zunaid!  You have been assigned to this bug

Comment 2

[Zunaid Amin Enan]

Getting on to it right now :p Setting up my build environment =D

Comment 3

[Atique Ahmed Ziad [:atiqueahmedziad]]

Congratz Zunaid for building fireplace locally. 

Now can you please check this line -https://github.com/mozilla/fireplace/blob/master/src/media/js/views/settings.js#L54

Will you please try changing the string on that line ? We need to put "Settings" instead of "Account Settings" there. 

If you are done then please send a pull request to Fireplace/master

If you have any questions let me know :)

Comment 4

[Zunaid Amin Enan]

Attachment: Pull request

Thanks for the suggestion :)

Comment 5

[Atique Ahmed Ziad [:atiqueahmedziad]]

Comment on attachment 8622059 [details] [review]
Pull request

looks good ... thanks :)

Comment 6

[Atique Ahmed Ziad [:atiqueahmedziad]]

https://github.com/mozilla/fireplace/commit/7866c96f84ce56948f95b7c64a046448f14c23d8