Closed
Bug 1172491
Opened 10 years ago
Closed 10 years ago
Enable e10s in safe mode
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: jimm, Assigned: mconley)
References
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
Felipe
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
e10s is stable enough to run under safemode. addon stability is our biggest issue currently, e10s + safemode will help diagnose these issues.
![]() |
Reporter | |
Updated•10 years ago
|
Summary: Don't disable e10s in safemode → Enable e10s in safe mode
Updated•10 years ago
|
Assignee: nobody → mconley
Assignee | ||
Comment 1•10 years ago
|
||
Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8620439 [details]
MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
Attachment #8620439 -
Flags: review?(felipc)
Assignee | ||
Comment 3•10 years ago
|
||
https://reviewboard.mozilla.org/r/10753/#review9417
::: toolkit/xre/nsAppRunner.cpp:4551
(Diff revision 1)
> - kE10sDisabledInSafeMode = 3,
> + // kE10sDisabledInSafeMode = 3, was removed in bug 1172491.
Not sure if this is necessary - I thought it'd help to illustrate why 3 was missing rather than leaving it out entirely.
Updated•10 years ago
|
Attachment #8620439 -
Flags: review?(felipc) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8620439 [details]
MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
https://reviewboard.mozilla.org/r/10755/#review9433
Ship It!
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8620439 [details]
MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
Approval Request Comment
[Feature/regressing bug #]:
N/A
[User impact if declined]:
Users testing multi-process Firefox on Aurora might erroneously assume that an add-on is to blame for a particular problem if it goes away in safe mode. This should make it easier for us to detect when a problem is occurring with in the browser+e10s, or an add-on.
[Describe test coverage new/current, TreeHerder]:
There are some tests for safe mode, which we're currently passing.
[Risks and why]:
This is very low risk. We're basically removing a check for safe mode when deciding if we should be using multi-process Firefox.
[String/UUID change made/needed]:
None.
Attachment #8620439 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox40:
--- → affected
Updated•10 years ago
|
Attachment #8620439 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•10 years ago
|
||
Mike landed this:
https://hg.mozilla.org/releases/mozilla-aurora/rev/48f907ce97b6
![]() |
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•