1172491 - Enable e10s in safe mode

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jim Mathies [:jimm]]

e10s is stable enough to run under safemode. addon stability is our biggest issue currently, e10s + safemode will help diagnose these issues.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe

Bug 1172491 - Let e10s be enabled in safe mode. r?felipe

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8620439 [details]
MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe

Bug 1172491 - Let e10s be enabled in safe mode. r?felipe

Comment 3

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/10753/#review9417

::: toolkit/xre/nsAppRunner.cpp:4551
(Diff revision 1)
> -  kE10sDisabledInSafeMode = 3,
> +  // kE10sDisabledInSafeMode = 3, was removed in bug 1172491.

Not sure if this is necessary - I thought it'd help to illustrate why 3 was missing rather than leaving it out entirely.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8620439 [details]
MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe

https://reviewboard.mozilla.org/r/10755/#review9433

Ship It!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/17b12a456537

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17b12a456537

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8620439 [details]
MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe

Approval Request Comment
[Feature/regressing bug #]:

N/A

[User impact if declined]:

Users testing multi-process Firefox on Aurora might erroneously assume that an add-on is to blame for a particular problem if it goes away in safe mode. This should make it easier for us to detect when a problem is occurring with in the browser+e10s, or an add-on.

[Describe test coverage new/current, TreeHerder]:

There are some tests for safe mode, which we're currently passing.

[Risks and why]: 

This is very low risk. We're basically removing a check for safe mode when deciding if we should be using multi-process Firefox.

[String/UUID change made/needed]:

None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Mike landed this:
https://hg.mozilla.org/releases/mozilla-aurora/rev/48f907ce97b6