Closed Bug 1172491 Opened 10 years ago Closed 10 years ago

Enable e10s in safe mode

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s m7+ ---
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: jimm, Assigned: mconley)

References

Details

Attachments

(1 file)

e10s is stable enough to run under safemode. addon stability is our biggest issue currently, e10s + safemode will help diagnose these issues.
Summary: Don't disable e10s in safemode → Enable e10s in safe mode
Assignee: nobody → mconley
Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
Comment on attachment 8620439 [details] MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe Bug 1172491 - Let e10s be enabled in safe mode. r?felipe
Attachment #8620439 - Flags: review?(felipc)
https://reviewboard.mozilla.org/r/10753/#review9417 ::: toolkit/xre/nsAppRunner.cpp:4551 (Diff revision 1) > - kE10sDisabledInSafeMode = 3, > + // kE10sDisabledInSafeMode = 3, was removed in bug 1172491. Not sure if this is necessary - I thought it'd help to illustrate why 3 was missing rather than leaving it out entirely.
Attachment #8620439 - Flags: review?(felipc) → review+
Comment on attachment 8620439 [details] MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe https://reviewboard.mozilla.org/r/10755/#review9433 Ship It!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8620439 [details] MozReview Request: Bug 1172491 - Let e10s be enabled in safe mode. r?felipe Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Users testing multi-process Firefox on Aurora might erroneously assume that an add-on is to blame for a particular problem if it goes away in safe mode. This should make it easier for us to detect when a problem is occurring with in the browser+e10s, or an add-on. [Describe test coverage new/current, TreeHerder]: There are some tests for safe mode, which we're currently passing. [Risks and why]: This is very low risk. We're basically removing a check for safe mode when deciding if we should be using multi-process Firefox. [String/UUID change made/needed]: None.
Attachment #8620439 - Flags: approval-mozilla-aurora?
Attachment #8620439 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1174857
Blocks: 1177499
No longer blocks: 1177499
Depends on: 1177499
Depends on: 1177838
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: