Closed
Bug 1172538
Opened 9 years ago
Closed 9 years ago
make sure a document has an IPC actor before shutting it down
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox39 | --- | unaffected |
firefox40 | --- | unaffected |
firefox41 | + | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
(Keywords: regression, topcrash)
Crash Data
Attachments
(1 file)
1.01 KB,
patch
|
lsocks
:
review+
davidb
:
review+
|
Details | Diff | Splinter Review |
If a document is shutdown before ever being bound to a parent document it doesn't have an associated IPC actor, so we shouldn't try and shut one down.
Assignee | ||
Comment 1•9 years ago
|
||
If a document is shutdown before ever being bound to a parent document it doesn't have an associated IPC actor, so we shouldn't try and shut one down.
Attachment #8616721 -
Flags: review?(lorien)
Attachment #8616721 -
Flags: review?(dbolter)
Comment 2•9 years ago
|
||
Comment on attachment 8616721 [details] [diff] [review] make sure a document has an IPC actor before shutting it down Review of attachment 8616721 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/generic/DocAccessible.cpp @@ +454,5 @@ > > mChildDocuments.Clear(); > > // XXX thinking about ordering? > + if (mIPCDoc && IPCAccessibilityActive()) { I guess we don't need the second check, in live review you suggested maybe just making it an assert.
Attachment #8616721 -
Flags: review?(dbolter) → review+
Updated•9 years ago
|
Attachment #8616721 -
Flags: review?(lorien)
Attachment #8616721 -
Flags: review+
Updated•9 years ago
|
Attachment #8616721 -
Flags: review+
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/076f168c0a91
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 6•9 years ago
|
||
Should this fix be in 20150610030209, or do I need to wait for another build?
Comment 7•9 years ago
|
||
(In reply to Shawn Wilsher :sdwilsh from comment #6) > Should this fix be in 20150610030209, or do I need to wait for another build? Wait for today's nightly, judging by the timestamp you posted and comment #4 .
Updated•9 years ago
|
Crash Signature: [@ mozilla::a11y::DocAccessible::Shutdown()]
Comment 9•9 years ago
|
||
This is a huge top crash in nightly only, so it seems like it must be a regression.
Comment 10•9 years ago
|
||
Tracking in 41 because it is a top crash, and untracked its duplicate.
tracking-firefox41:
--- → +
You need to log in
before you can comment on or make changes to this bug.
Description
•