1172538 - make sure a document has an IPC actor before shutting it down

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

If a document is shutdown before ever being bound to a parent document it
doesn't have an associated IPC actor, so we shouldn't try and shut one down.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: make sure a document has an IPC actor before shutting it down

If a document is shutdown before ever being bound to a parent document it
doesn't have an associated IPC actor, so we shouldn't try and shut one down.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8616721 [details] [diff] [review]
make sure a document has an IPC actor before shutting it down

Review of attachment 8616721 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/DocAccessible.cpp
@@ +454,5 @@
>  
>    mChildDocuments.Clear();
>  
>    // XXX thinking about ordering?
> +  if (mIPCDoc && IPCAccessibilityActive()) {

I guess we don't need the second check, in live review you suggested maybe just making it an assert.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/076f168c0a91

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/076f168c0a91

Comment 6

[Shawn Wilsher :sdwilsh]

Should this fix be in 20150610030209, or do I need to wait for another build?

Comment 7

[:Gijs (he/him)]

(In reply to Shawn Wilsher :sdwilsh from comment #6)
> Should this fix be in 20150610030209, or do I need to wait for another build?

Wait for today's nightly, judging by the timestamp you posted and comment #4 .

Comment 9

[Liz Henry (:lizzard)]

This is a huge top crash in nightly only, so it seems like it must be a regression.

Comment 10

[Kate Glazko]

Tracking in 41 because it is a top crash, and untracked its duplicate.