1172598 - [Lint: deprecated] plugin_container's AbsoluteLayout is deprecated

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via lint:

../../src/main/res/layout/shared_ui_components.xml:17: AbsoluteLayout is deprecated

  14                                  android:layout_width="match_parent"
  15                                  android:layout_height="match_parent"/>
  16 
  17     <AbsoluteLayout android:id="@+id/plugin_container"
  18                     android:background="@android:color/transparent"
  19                     android:layout_width="match_parent"

---

A quick Google suggests AbsoluteLayout can be replaced with a RelativeLayout (though I wonder about the perf impact here as RelativeLayouts are typically expensive).

Snorp, how challenging is this? Mentorable?

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think it's still the right thing to use AbsoluteLayout here. We for real want to place the view at specific x,y with a specific width/height, so I think it's the correct thing. A custom container could work instead, I guess, if we don't want to use a deprecated class.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #1)
> A custom container could work instead, I
> guess, if we don't want to use a deprecated class.

I'm afraid of it getting removed (e.g. FloatMath) and us having very little time to do something about it (and make sure it's bug-free).

Can you mentor this or assign someone?

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Michael Comella (:mcomella) from comment #2)
> (In reply to James Willcox (:snorp) ([e-mail]) from comment #1)
> > A custom container could work instead, I
> > guess, if we don't want to use a deprecated class.
> 
> I'm afraid of it getting removed (e.g. FloatMath) and us having very little
> time to do something about it (and make sure it's bug-free).
> 
> Can you mentor this or assign someone?

We only need it for plugins on Gingerbread, so I don't think we need to worry about that too much. If someone wants to move it to something else, that's fine.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

comment 3 says we only need it for GB – let's kill this when we kill GB.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Snorp, you mentioned this is only needed for GB – what needs to be done to remove the AbsoluteLayout?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

We *might* still need it for fullscreen mode. Dylan can you look into that?

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.