Closed
Bug 1172664
Opened 9 years ago
Closed 9 years ago
Use [NSApplication setPresentationOptions:] instead of SetSystemUIMode for hide os chrome
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
1.61 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
As we have dropped 10.5 support for a long time, we can use the new [NSApplication setPresentationOptions:] instead of SetSystemUIMode in nsCocoaUtils::HideOSChromeOnScreen() as commented in that function.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8616917 -
Flags: review?(mstange)
Comment 2•9 years ago
|
||
Comment on attachment 8616917 [details] [diff] [review] patch Looks fine to me. For the record, the relevant docs are here: https://developer.apple.com/library/mac/documentation/Carbon/Reference/Dock_Manager/index.html#//apple_ref/c/tdef/SystemUIMode https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSApplication_Class/index.html#//apple_ref/c/tdef/NSApplicationPresentationOptions
Attachment #8616917 -
Flags: review?(mstange) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f41ed84e4216
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Adding a tracking flag for FF41 so we verify and test the fix.
tracking-firefox41:
--- → +
You need to log in
before you can comment on or make changes to this bug.
Description
•