1172867 - [Statusbar][Performance] Statusbar shouldn't reflow when pulling down the utility tray

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Alberto Pastor [:albertopq]]

Pulling down the utility tray feels slow cause of the statusbar being reflowed every time the grippy hides it.

Comment 1

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30489

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Video: https://www.youtube.com/watch?v=WMdHEShdu5A&feature=youtu.be

Take a look to the number of reflows we avoid with the patch

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8617250 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30489

Naoki, although I already checked that all the UI tests are passing, could somebody in QA take a look in order to make sure it doesn't break anything related to statusbar colors (ie. after coming from an activity, task switcher, lockscreen, etc)?

Thanks!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8617250 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30489

This is amazing work, Alberto! Feels ridiculously better.

I left some questions on github, chief of which is the test changes which might make us need to block on bug 1168915. Please re-flag me once those questions are answered.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8617250 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30489

This is amazing work, Alberto! Feels ridiculously better.

I left some questions on github, chief of which is the test changes which might make us need to block on bug 1168915. Please re-flag me once those questions are answered.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QAWANTED: Testing for Spark Gaia.

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

Tested the patch on both Flame and Aries. I noticed an issue on both devices after patch - when utility tray is pulled down, status bar icons become bolded. (similar to bug 1162284, but this happens when utility tray is pulled down, and persists until the tray is pulled up)

Other than that everything looks normal.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8617250 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30489

LGTM. Please figure out why the Video app is showing a 1 second launch regression time in treeeherder. I don't think it's related to your patch, but please make sure before landing.

https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/AMnbQ94wSeq3AhA0Sr4ImA/2/public/logs/live_backing.log

Comment 9

[Alberto Pastor [:albertopq]]

Everything green after rebasing:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=274037e25a0c0581615e80aef8a6b2fcff68cfa7

master: https://github.com/mozilla-b2g/gaia/commit/1d852d0acb3ae92fd8495e997fb7e070a7ee9295