Closed Bug 1172947 Opened 9 years ago Closed 9 years ago

Improve tour panel footer style on Windows

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
Windows
Type:
defect
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 42
Iteration:
42.1 - Jul 13
Tracking Flags:
Tracking Status
firefox42 --- verified

People

(Reporter: phlsa, Assigned: bgrins)

References

Details

(Whiteboard: [fxprivacy] [ux-qx] [campaign])

Attachments

(4 files)

current tour panel borders.png
178.00 KB, image/png
Details
MozReview Request: Bug 1172947 - Set proper margin on #UITourTooltipButtons so it properly extends to the edges of the #UITourTooltip;r=MattN
40 bytes, text/x-review-board-request
MattN
: review+
Details
uitour-win7.png
29.33 KB, image/png
Details
uitour-win10.png
48.81 KB, image/png
Details 
When a tour panel has a footer, there is a margin around it that makes it look out of place. We should either remove that margin or re-style the footer.
Isn't this a regression?
Flags: needinfo?(philipp)
Flags: needinfo?(MattN+bmo)
I don't know. I don't recall seeing it work normally on Windows and the behavior is the same in Release and Nightly.
Flags: needinfo?(philipp)
Whiteboard: [ux-qx][ux] → [ux-qx] [ux] [fxprivacy]
Flags: needinfo?(MattN+bmo) → firefox-backlog+
Hi Matt, is there a user story this bug is related to?
Flags: needinfo?(MattN+bmo)
Is not a regression. It was always so.
It's related to a few, at least: bug 1175016 & bug 1175014.
Blocks: 1175016, 1175014
Flags: needinfo?(MattN+bmo)
Rank: 17
Priority: -- → P1
Summary: [UX] Improve tour panel footer style on Windows → Improve tour panel footer style on Windows
Whiteboard: [ux-qx] [ux] [fxprivacy] → [ux-qx] [fxprivacy]
Points: --- → 5
Flags: qe-verify+
Points: 5 → 3
I'll take a look at this
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Bug 1172947 - Set proper margin on #UITourTooltipButtons so it properly extends to the edges of the #UITourTooltip;r=MattN
Attachment #8631888 - Flags: review?(MattN+bmo)
Attached image uitour-win7.png — 
screenshot with patch applied on windows 7
Attached image uitour-win10.png — 
screenshot with patch applied on windows 10
Iteration: --- → 42.1 - Jul 13
QA Contact: mwobensmith
Comment on attachment 8631888 [details]
MozReview Request: Bug 1172947 - Set proper margin on #UITourTooltipButtons so it properly extends to the edges of the #UITourTooltip;r=MattN

https://reviewboard.mozilla.org/r/12953/#review11567

Ship It!
Attachment #8631888 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/424e90c44530
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Whiteboard: [ux-qx] [fxprivacy] → [fxprivacy] [ux-qx] [campaign]
Verified on both Win7 and Win10, Fx42.0a1, 2015-07-30.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: