[Contacts][NGA] Extract 'goToSelectTag' functionality to it own .js class

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::Contacts
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: borjasalguero, Assigned: jorgep)

Tracking

(Blocks: 1 bug)

unspecified
FxOS-S1 (26Jun)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-master fixed)

Details

(Whiteboard: [NG Gaia Contacts])

Attachments

(1 attachment)

384 bytes, text/html
borjasalguero
: review+
arcturus
: review+
Details
(Reporter)

Description

2 years ago
We need to extract from contact.js the functionality not related with contacts, in order to have a reusable and modular code.

In this bug we will generate a 'TagSelector' object, which will expose a 'show' and 'hide' for being used in 'forms.js'.
(Reporter)

Updated

2 years ago
Blocks: 1169191
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → NGA S2 (12Jun)
(Assignee)

Updated

2 years ago
Assignee: nobody → jpruden92
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8617864 [details]
30515.html
Attachment #8617864 - Flags: feedback?(borja.bugzilla)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8617864 [details]
30515.html

Some comments to address! Let me know when the patch will be ready and I'll take a look again. Great job!
Attachment #8617864 - Flags: feedback?(borja.bugzilla)
(Assignee)

Updated

2 years ago
Attachment #8617864 - Flags: review?(francisco)
Attachment #8617864 - Flags: review?(borja.bugzilla)
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
(Reporter)

Comment 3

2 years ago
Comment on attachment 8617864 [details]
30515.html

Great job! Ensure all tests are in green before merging. Thanks!
Attachment #8617864 - Flags: review?(borja.bugzilla) → review+
Comment on attachment 8617864 [details]
30515.html

LGTM, left a comment on github about when we should load the new script.

Giving the r+ but please fix that first.

Thanks!
Attachment #8617864 - Flags: review?(francisco) → review+
(Reporter)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
status-b2g-master: --- → fixed
Blocks: 1175819
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in before you can comment on or make changes to this bug.