Closed Bug 1173097 Opened 5 years ago Closed 5 years ago
[Contacts][NGA] Extract 'go
To Select Tag' functionality to it own .js class
We need to extract from contact.js the functionality not related with contacts, in order to have a reusable and modular code. In this bug we will generate a 'TagSelector' object, which will expose a 'show' and 'hide' for being used in 'forms.js'.
Comment on attachment 8617864 [details] 30515.html Some comments to address! Let me know when the patch will be ready and I'll take a look again. Great job!
Comment on attachment 8617864 [details] 30515.html Great job! Ensure all tests are in green before merging. Thanks!
Attachment #8617864 - Flags: review?(borja.bugzilla) → review+
Comment on attachment 8617864 [details] 30515.html LGTM, left a comment on github about when we should load the new script. Giving the r+ but please fix that first. Thanks!
Attachment #8617864 - Flags: review?(francisco) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in before you can comment on or make changes to this bug.