1173097 - [Contacts][NGA] Extract 'goToSelectTag' functionality to it own .js class

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to extract from contact.js the functionality not related with contacts, in order to have a reusable and modular code.

In this bug we will generate a 'TagSelector' object, which will expose a 'show' and 'hide' for being used in 'forms.js'.

Comment 1

[Jorge Prudencio [:jorgep]]

Attachment: 30515.html

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8617864 [details]
30515.html

Some comments to address! Let me know when the patch will be ready and I'll take a look again. Great job!

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8617864 [details]
30515.html

Great job! Ensure all tests are in green before merging. Thanks!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8617864 [details]
30515.html

LGTM, left a comment on github about when we should load the new script.

Giving the r+ but please fix that first.

Thanks!

Comment 5

[Maria Angeles Oteo (:oteo)]

As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed