Closed Bug 1173114 Opened 5 years ago Closed 5 years ago

Add some better handling for the case where runtimes.json is missing

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently error out if --chunk-by-runtime is specified and there isn't an appropriate runtimes.json file.  This is kind of bad, since it's easy to miss these files...we don't run all platforms/build types in try, and there are cases, like standing up a new platform, or a new version of existing tests (e.g., e10s) where good runtimes.json files won't exist yet.

Ultimately, we might solve this problem by using a generic runtimes.json file. In the meantime, let's fall back intelligently to chunk-by-dir or chunk-by-slice.
turns out we already use --chunk-by-dir for mochitest-plain

trying (by deleting some runtimes files):   https://treeherder.mozilla.org/#/jobs?repo=try&revision=544195e2c8ce
Try run shows this worked; the linux64opt runtimes files were deleted there, and the log shows it correctly reverted to --chunk-by-dir
Attachment #8620419 - Flags: review?(ahalberstadt)
Comment on attachment 8620419 [details] [diff] [review]
Fallback to chunk-by-dir if runtimes file not found,

Review of attachment 8620419 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, thanks for tackling all these issues!
Attachment #8620419 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/a97be435ed02
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.