1173114 - Add some better handling for the case where runtimes.json is missing

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonathan Griffin (:jgriffin)]

We currently error out if --chunk-by-runtime is specified and there isn't an appropriate runtimes.json file.  This is kind of bad, since it's easy to miss these files...we don't run all platforms/build types in try, and there are cases, like standing up a new platform, or a new version of existing tests (e.g., e10s) where good runtimes.json files won't exist yet.

Ultimately, we might solve this problem by using a generic runtimes.json file. In the meantime, let's fall back intelligently to chunk-by-dir or chunk-by-slice.

Comment 1

[Jonathan Griffin (:jgriffin)]

turns out we already use --chunk-by-dir for mochitest-plain

trying (by deleting some runtimes files):   https://treeherder.mozilla.org/#/jobs?repo=try&revision=544195e2c8ce

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Fallback to chunk-by-dir if runtimes file not found,

Try run shows this worked; the linux64opt runtimes files were deleted there, and the log shows it correctly reverted to --chunk-by-dir

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8620419 [details] [diff] [review]
Fallback to chunk-by-dir if runtimes file not found,

Review of attachment 8620419 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm, thanks for tackling all these issues!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a97be435ed02

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a97be435ed02

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/21380dd34484