Closed
Bug 1173201
Opened 10 years ago
Closed 10 years ago
Tests are failing when looking for about:home tabs
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
Bug 1137051 changed about: URLs to return nil, which broke tests that are looking for about:home tabs. We should still use some kind of accessibility label for these tabs so that a) we help VoiceOver users, and b) we can identify these tabs in KIF tests.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8617673 -
Flags: review?(wjohnston)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Note that this still leaves the user-visible label empty for about: tabs, which is probably fine. I doubt we want to expose "about:home" or "home" text.
|
||
Updated•10 years ago
|
tracking-fxios:
--- → ?
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8617673 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/582
Looks like wesj didn't get to this in time before his PTO, so redirecting.
Attachment #8617673 -
Flags: review?(wjohnston) → review?(sarentz)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8617673 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/582
LGTM
Attachment #8617673 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•