1173209 - I need a short menu button. My phone doesn't have a hardware button. I am using the beta for android

Status: RESOLVED DUPLICATE of bug 1209902

(Firefox for Android Graveyard :: General, defect)

Description

[sid]

Attachment: tmp_523-Screenshot_2015-06-10-06-14-38-1568217484.png

User Agent: Mozilla/5.0 (Android; Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
Build ID: 20150601170656

Steps to reproduce:

Using a device without the hardware menu button enabled


Actual results:

No way to access the menu


Expected results:

A way to access the menu in the ui

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to sid from comment #0)
> Using a device without the hardware menu button enabled

What device are you using and which version of Android?

Is the hardware menu button disabled by default or did you have to enter some setting to change this?

(Previous work in this field is related to bug 1024717)

Comment 2

[Hans Schmucker]

The issue also appears on the OnePlus X using OxygenOS 2.1.2 using Fennec 42. The OnePlus X has hardbuttons, but no hardware menu button. Enabling the softbuttons also fixes the issue with the button appearing appearing at the top right.

So you need anything else? Is there a pref that can temporarily override the detected button configuration?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The option to display a temporary override on 4.*+ devices is an interesting one, though it could confuse users who already have the software menu key. I'll leave it up to triage.

It looks like we call out to `ViewConfiguration.hasPermanentMenuKey` [1][2]. We can dig into why this is not true, but it's worth noting that this will be solved by bug 1209967, where we will display the soft menu button all the time.

I don't think there is anything else we need, thanks!

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/util/HardwareUtils.java?rev=86b6e026fbc4#61
[2]: https://developer.android.com/reference/android/view/ViewConfiguration.html#hasPermanentMenuKey%28%29

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

This is more or less a duplicate of bug 1209902. OnePlus devices pretend to have a hardware menu button [ViewConfiguration.hasPermanentMenuKey] (because you /can/ have a button to act as menu button) and therefore we do not show the overflow menu.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Work-around though ideally we ship bug 1209967.

(In reply to Swarnava Sengupta (:Swarnava) from bug 1209902 comment #4)
> Created attachment 8667893 [details]
> tmp_31233-IMG_20150930_1957231229941341.jpg
> 
> It doesn't have the three dots, but if you long press the window key,it
> opens the options