crash in mozilla::net::HttpBaseChannel::OverrideSecurityInfo(nsISupports*)

VERIFIED FIXED in Firefox 41

Status

()

--
critical
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({crash})

unspecified
mozilla41
Unspecified
Mac OS X
crash
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 verified)

Details

(crash signature)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
This bug was filed from the Socorro interface and is 
report bp-30490d4c-171c-42c3-8e9d-9ba232150610.
=============================================================

I got this crash when I was testing trained to thrill.

Updated

3 years ago
status-firefox41: --- → affected
(Assignee)

Comment 1

3 years ago
So far I have been unable to reproduce this under the debugger to see exactly what is going on...

Michal, since you asked me to turn this assertions to release asserts in bug 1133763 comment 59, does the fact that this assertion can be hit in practice change your mind?  I don't think this is something that we should crash on...
Blocks: 1133763
Flags: needinfo?(michal.novotny)
Agree, we shouldn't crash on this, but we also shouldn't silently ignore the unexpected state in release build. So what about failing here and keeping just a debug assertion?
Flags: needinfo?(michal.novotny)
(Assignee)

Comment 3

3 years ago
That sounds good to me!
(Assignee)

Comment 4

3 years ago
Created attachment 8621695 [details] [diff] [review]
Relax the release assertions for the service worker URI and security info overrides into debug mode assertions
(Assignee)

Updated

3 years ago
Attachment #8621695 - Flags: review?(michal.novotny)
Created attachment 8622089 [details] [diff] [review]
patch

I meant something like this.
Attachment #8622089 - Flags: review?(ehsan)
(Assignee)

Comment 6

3 years ago
Comment on attachment 8622089 [details] [diff] [review]
patch

Review of attachment 8622089 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, looks sane!
Attachment #8622089 - Flags: review?(ehsan) → review+
(Assignee)

Updated

3 years ago
Attachment #8621695 - Attachment is obsolete: true
Attachment #8621695 - Flags: review?(michal.novotny)
https://hg.mozilla.org/mozilla-central/rev/2e5641d6cd6f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Updated

3 years ago
Depends on: 1179399
Socorro [1] shows zero crashes over the past 4 weeks in builds that contain the fix.

[1] - https://crash-stats.mozilla.com/report/list?range_unit=days&range_value=28&signature=mozilla%3A%3Anet%3A%3AHttpBaseChannel%3A%3AOverrideSecurityInfo%28nsISupports%2A%29#tab-reports
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.