1173389 - Add a pref to disable fetch events in case we want to ship service workers for push first

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

This should hide self.onfetch, and prevent network interception.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Can we wait to do this until we are more sure that network interception will slip?

Comment 2

[(no longer active)]

I'm in no rush!

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98196eb774b2

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1173389 - Disable ServiceWorker network interception by default. r?ehsan

Bug 1173389 - Disable ServiceWorker network interception by default. r?ehsan

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

There is one new test for feature detection, the rest of the test changes are just adding the pref.

Comment 6

[(no longer active)]

Comment on attachment 8621906 [details]
MozReview Request: Bug 1173389 - Disable ServiceWorker network interception by default. r?ehsan

https://reviewboard.mozilla.org/r/11079/#review9755

Ship It!

::: dom/workers/test/serviceworkers/test_claim_oninstall.html:67
(Diff revision 1)
> +    ["dom.serviceWorkers.interception.enabled", true],

Please remove the second line.

::: dom/workers/test/serviceworkers/test_fetch_event.html:76
(Diff revision 1)
> +    ["dom.serviceWorkers.interception.enabled", true],

Ditto.

::: dom/workers/test/serviceworkers/test_interception_featuredetect.html:27
(Diff revision 1)
> +      }, function(e) {

Nit: Use .catch() ;-)

::: dom/workers/test/serviceworkers/test_interception_featuredetect.html:65
(Diff revision 1)
> +    ["dom.messageChannel.enabled", true],

Why do you need to enable MessageChannel?  I think this can be removed.

::: dom/workers/test/serviceworkers/test_interception_featuredetect.html:54
(Diff revision 1)
> +      .then(function() {

Please unregister the service worker before the end of the test.

::: dom/workers/test/serviceworkers/test_match_all_client_properties.html:92
(Diff revision 1)
> +    ["dom.serviceWorkers.interception.enabled", true],

Unneeded repetition.

::: dom/workers/test/serviceworkers/test_sanitize_domain.html:82
(Diff revision 1)
> +    ["dom.serviceWorkers.interception.enabled", true],

Same.

Comment 7

[(no longer active)]

BTW, I think you'd need to add these prefs to WPT tests as well.  r=me with that.

Comment 8

[(no longer active)]

And you should add these prefs to firefox.js and mobile.js under the same RELEASE_BUILDS conditions as dom.serviceWorkers.enabled.

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d8207b1b5eb

Comment 10

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/02f640a72dcd

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/02f640a72dcd