1153499 - [meta] Enable push notifications on Desktop

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Comment 1

[Andrew Overholt [:overholt]]

Status update: Kit or Nikhil can clarify but I'm under the impression that bug 1153500 and bug 1153504 are the remaining blockers to shipping push on Desktop.

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Bug 1153499 - Enable push and sw prefs. r?dougt,ehsan

Comment 3

[(no longer active)]

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

https://reviewboard.mozilla.org/r/14467/#review13103

::: modules/libpref/init/all.js:146
(Diff revision 1)
> +pref("dom.serviceWorkers.enabled", true);

You need to adjust the test_*interfaces tests for this.

Comment 4

[(no longer active)]

That is r-.  Not sure how to do that on ReviewBoard.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Bug 1153499 - Enable push and sw prefs. r?dougt,ehsan

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

https://reviewboard.mozilla.org/r/14467/#review13251

Ship It\!

Comment 7

[(no longer active)]

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

https://reviewboard.mozilla.org/r/14467/#review13459

Ship It!

::: modules/libpref/init/all.js:146
(Diff revision 2)
> +pref("dom.serviceWorkers.enabled", true);

I think instead of these #ifdefs, it would be better to move this to firefox.js.

::: modules/libpref/init/all.js:4447
(Diff revision 2)
>  pref("dom.push.enabled", true);

This too!

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=516c3b9ff872

Comment 10

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/95bd6642e4b1c4facd070773d91d00317e74deea
changeset:  95bd6642e4b1c4facd070773d91d00317e74deea
user:       Nikhil Marathe <[e-mail]>
date:       Wed Jul 15 13:12:44 2015 -0700
description:
Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This (and everything else in that push) backed out for mochitest-push crashes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15512b2f6f41

https://treeherder.mozilla.org/logviewer.html#?job_id=12539301&repo=mozilla-inbound

Comment 12

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/252814d5e628bdf69b1ecfd799fd94e44c1dd56f
changeset:  252814d5e628bdf69b1ecfd799fd94e44c1dd56f
user:       Nikhil Marathe <[e-mail]>
date:       Wed Jul 15 13:12:44 2015 -0700
description:
Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Comment 13

[Carsten Book [:Tomcat]]

backed out for test failures like :

https://treeherder.mozilla.org/logviewer.html#?job_id=12558193&repo=mozilla-inbound
and
https://treeherder.mozilla.org/logviewer.html#?job_id=12560533&repo=mozilla-inbound

Comment 14

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/752bf6f11fbf

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Moving the relnote tracking flag from bug 1153503 to here as it seems that the fun is occurring here:

Release Note Request (optional, but appreciated)
[Why is this notable]: Push notifications seems noteworthy.
[Suggested wording]: Implemented Push API
[Links (documentation, blog post, etc)]:

Comment 16

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a903cf6651

Comment 17

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b916cbec4e17

Comment 18

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e4d353f5798e3947a152c0aaea5e022c3cc27c
changeset:  f3e4d353f5798e3947a152c0aaea5e022c3cc27c
user:       Nikhil Marathe <[e-mail]>
date:       Wed Jul 15 13:12:44 2015 -0700
description:
Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3e4d353f579

Comment 20

[Florian Bender]

(In reply to Sylvestre Ledru [:sylvestre] from comment #15)
> Release Note Request (optional, but appreciated)
> [Why is this notable]: Push notifications seems noteworthy.
> [Suggested wording]: Implemented Push API
> [Links (documentation, blog post, etc)]:

I assume this is only available in ServiceWorkers? Then please mention that in the relnotes (to not confuse it with the different Push API implemented for Firefox OS):

[Suggested wording]: Implemented Push API via Service Workers
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Push_API

Comment 21

[Andrew Overholt [:overholt]]

I would rather say something like "not SimplePush, the FxOS-only API previously mentioned [here]" since we're not shipping the network interception functionality of Service Workers and don't want confusion by mentioning them.

Comment 22

[Sylvestre Ledru [:Sylvestre]]

(In reply to Andrew Overholt [:overholt] from comment #21)
> I would rather say something like "not SimplePush, the FxOS-only API
> previously mentioned [here]" since we're not shipping the network
> interception functionality of Service Workers and don't want confusion by
> mentioning them.
I am not sure to understand what you are proposing. Could you propose a wording? Thanks

Comment 23

[Andrew Overholt [:overholt]]

[Suggested wording]: Implemented Push API (note: not the same as SimplePush [https://developer.mozilla.org/en-US/docs/Web/API/Simple_Push_API], the FxOS-only API)
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Push_API

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Sorry but most of the Firefox users/developers won't make a confusion with Firefox OS.
Moreover, this is clearly stated in the documentation.
So, I am using Florian proposal for the release notes "Implemented Push API via Service Workers"

Comment 25

[Andrew Overholt [:overholt]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #24)
> Sorry but most of the Firefox users/developers won't make a confusion with
> Firefox OS.

But Florian's reason for noting "via Service Workers" was due to potential confusion (see comment 20) :)

I just don't want to have people think we're shipping all of Service Workers.  Please take that into account with your wording.

Thanks.

Comment 26

[Florian Bender]

I tried to word it so it is less likely to be confused without being overly long/complicated. For the release, a blog post can point out that although service workers are exposed for the Push functionality, the offline/caching functionality is not yet exposed.

Is there a way to notify HMO writers that they should consider this in their write-ups? Also, someone may write a blog post highlighting the new Push functionality (while pointing out the above) that the release notes can link to.

Comment 27

[jweathersby]

(In reply to Andrew Overholt [:overholt] from comment #25)
> (In reply to Sylvestre Ledru [:sylvestre] from comment #24)
> > Sorry but most of the Firefox users/developers won't make a confusion with
> > Firefox OS.
> 
> But Florian's reason for noting "via Service Workers" was due to potential
> confusion (see comment 20) :)
> 
> I just don't want to have people think we're shipping all of Service
> Workers.  Please take that into account with your wording.
> 
> Thanks.

+1

I think it better to just say the Push API is available. We can do a hacks post on it which can clarify if needed. If we say SW we need to say something like "The path to full Service Workers continues with the implementation of the Push API"

Comment 28

[Chris Mills [:cmills]]

The Push API has been documented at:

https://developer.mozilla.org/en-US/docs/Web/API/Push_API

See also the interface reference pages (and their member subpages)

https://developer.mozilla.org/en-US/docs/Web/API/PushEvent
https://developer.mozilla.org/en-US/docs/Web/API/PushManager
https://developer.mozilla.org/en-US/docs/Web/API/PushMessageData
https://developer.mozilla.org/en-US/docs/Web/API/PushSubscription

the SW additions:

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/pushManager
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/onpush
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/onpushsubscriptionchange

and a basic usage guide:

https://developer.mozilla.org/en-US/docs/Web/API/Push_API/Using_the_Push_API

A tech review would be nice at some point. Thanks!

Comment 29

[Sylvestre Ledru [:Sylvestre]]

Wording updated to "Ship Push messaging with disabled web notifications from ServiceWorkers"
(thanks to Martin Best for the suggestion).

Comment 30

[Chris Mills [:cmills]]

I've added a note to make this clear in the web notifications compat table, and updated the description in the release notes:

https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API#Browser_compatibility
https://developer.mozilla.org/en-US/Firefox/Releases/42#Service_Workers