Closed
Bug 1173393
Opened 9 years ago
Closed 9 years ago
Perf detail views should have unique EventTargets
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
|
5.80 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
JIT view binds an event on the "focus" event of JsCallTreeView, which comes from the tree view there. Not sure how that bleeds from MemoryCallTreeView.
TypeError: view is undefined: JITOptimizationsView._onFocusFrame@chrome://browser/content/devtools/performance/views/jit-optimizations.js:405:9
EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:147:11
MemoryCallTreeView<._populateCallTree/<@chrome://browser/content/devtools/performance/views/details-memory-call-tree.js:109:28
EventEmitter_emit@resource://gre/modules/devtools/event-emitter.js:147:11
AbstractTreeItem.prototype._onFocus@resource:///modules/devtools/AbstractTreeItem.jsm:579:5
AbstractTreeItem.prototype.focus@resource:///modules/devtools/AbstractTreeItem.jsm:287:5
AbstractTreeItem.prototype._onClick@resource:///modules/devtools/AbstractTreeItem.jsm:526:5
|
Assignee | |
Comment 1•9 years ago
|
||
Apparently all these views share the same EventTarget.
Summary: Clicking an allocations frame in allocations call tree throws JIT view error → Perf detail views should have unique EventTargets
|
|
Assignee | |
Comment 2•9 years ago
|
||
This could be extended more, but making separate bugs for that in the perf-extend meta bug (which I've yet to submit I guess).
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2b570f03487
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8620424 [details] [diff] [review]
1173393-eventbleed.patch
Review of attachment 8620424 [details] [diff] [review]:
-----------------------------------------------------------------
AHAHAHAHHA *cries*
Attachment #8620424 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•