1173583 - Make autocompletion from the username field work outside of <form>

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Matthew N. [:MattN]]

onUsernameInput currently does:
`
var acForm = acInputField.form
`
_autoCompleteSearchAsync currently does:
`
let form = aElement.form;
`

Both of these doesn't work if the input isn't in a field. These method needs to be able to get a FormLike for the username field. In the meantime, autocomplete for username fields outside of a real <form> won't work.

Comment 1

[Matthew N. [:MattN]]

_autoCompleteSearchAsync really just needs the form action origin which we know for FormLikes is the same as the form origin.

Comment 2

[Matthew N. [:MattN]]

We can fix this using the new API added in bug 1192081:
`form = FormLikeFactory.createFromField(inputElement);`

onUsernameInput code to be changed:
https://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/LoginManagerContent.jsm?rev=87cace3f3eac&mark=246,249-252,512-514#494

_autoCompleteSearchAsync code to be changed:
https://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/LoginManagerContent.jsm?rev=87cace3f3eac&mark=246,249-252,512-514#243

Tests can be added to toolkit/components/passwordmgr/test/test_basic_form_autocomplete.html:
e.g. add a fake "form" with a <div>:
`
   <div id="form11">
     <input  type="text"       name="uname" id="uname11">
     <input  type="password"   name="pword" id="pword11">
     <button type="submit">Submit</button>
   </form>
`
to test <form>-less autocomplete.

Comment 3

[Andrew Krawchyk]

Attachment: MozReview Request: Bug 1173583 - Make autocompletion from the username field work outside of <form>. r=MattN

Bug 1173583 - Make autocompletion from the username field work outside of <form>. r=MattN

Comment 4

[Andrew Krawchyk]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b937a10046fc

Comment 5

[Matthew N. [:MattN]]

Sorry about the delay. I'll try look at this ASAP. End-of-cycle work has been distracting me.

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8680857 [details]
MozReview Request: Bug 1173583 - Make autocompletion from the username field work outside of <form>. r=MattN

https://reviewboard.mozilla.org/r/23687/#review21799

Perfect! Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4d8bd0c31603

Comment 8

[Matthew N. [:MattN]]

Hi Andrew, would you be interested in working on other password manager bugs?

* Bug 1058438 is a bit bigger but not overly complex and would cleanup quite a bit of custom code.
* Bug 1217134 involves a bit of CSS and markup and is nice polish for a feature we'd like to ship.

You can find me as MattN on IRC if you would like other suggestions or help.

Thanks

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d8bd0c31603