Bug 1119035 (formless-logins)

Support capturing and filling login credentials on web pages that don't use <form> elements or trigger submit events

NEW
Unassigned

Status

()

Toolkit
Password Manager
P1
normal
2 years ago
6 months ago

People

(Reporter: ckarlof, Unassigned)

Tracking

(Depends on: 4 bugs, Blocks: 5 bugs, {meta})

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [passwords:heuristics], URL)

User Story

As a user I want PM to correctly fill a login for my favorite site that has incorrect or strange use of forms and fields.
(Reporter)

Description

2 years ago
Some sites (e.g., http://www.hulu.com/) don't use a <form> element in its login experience. The existing password manager code can't capture and fill the user's username and password unless the login page uses a <form> element. This is a breakdown bug for the password manager to support such sites.
(Reporter)

Updated

2 years ago
Blocks: 1119083
(Reporter)

Updated

2 years ago
Summary: Breakdown: Support capturing and filling login credentials on web pages that don't use <form> elements → Breakdown: Support capturing and filling login credentials on web pages that don't use <form> elements or trigger submit events
(Reporter)

Updated

2 years ago
Blocks: 787801
(Reporter)

Updated

2 years ago
Priority: -- → P1
This could be split into two parts, although they're a bit intertwined. Filling an already-saved login into a page without a <form> (just a password and username field) should be fairly straightforward to do. But saving the login is harder, because there's no formsubmit event to trigger it. But this is also a general problem we want to solve, since this can happen even when there's a form (eg <img src=login.jpg oncick="doLogin()">)
(Reporter)

Comment 2

2 years ago
The heuristic of

1) we have captured login data and the visibility of the password field went from visible -> not visible, or
2) we have captured some login data and a new page load happened

to trigger the showing of the capture dialog has worked for me in the past. This heuristic requires that we capture user input as the user enters it, rather than wait for a specific event (e.g., onsubmit). 

It's not perfect, of course, but nothing is. It can get challenging when dealing with change password pages, because sometimes those pages always show a password field. 

I, of course, generally encourage more creative thinking about this.
(Reporter)

Comment 3

2 years ago
> This heuristic requires that we capture user input as the user enters it, rather than wait for a specific event (e.g., onsubmit). 

For related discussion of this idea, see https://bugzilla.mozilla.org/show_bug.cgi?id=1119077#c1
Blocks: 1120860
Duplicate of this bug: 1130783
Depends on: 1132211
No longer blocks: 1120860
(Reporter)

Updated

2 years ago
Whiteboard: [blocked]
Blocks: 1156601
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Points: --- → 5
Flags: qe-verify-
Flags: firefox-backlog+
Whiteboard: [blocked]
Iteration: --- → 40.3 - 11 May

Updated

2 years ago
Iteration: 40.3 - 11 May → 41.1 - May 25

Updated

2 years ago

Updated

2 years ago
User Story: (updated)

Updated

2 years ago
Whiteboard: Heuristics+Recipes
Depends on: 1166947
Depends on: 1166965
Depends on: 1166995
Depends on: 1166998
Alias: formless-logins
Assignee: MattN+bmo → nobody
Status: ASSIGNED → NEW
Iteration: 41.1 - May 25 → ---
Points: 5 → ---
User Story: (updated)
Flags: qe-verify-
Keywords: meta
Summary: Breakdown: Support capturing and filling login credentials on web pages that don't use <form> elements or trigger submit events → Support capturing and filling login credentials on web pages that don't use <form> elements or trigger submit events
Depends on: 1167044

Updated

2 years ago
Blocks: 1167657

Updated

2 years ago
Whiteboard: Heuristics+Recipes → Heuristics-Recipes:passwords
Depends on: 1168707

Updated

2 years ago
No longer blocks: 1167657
Depends on: 1173583
No longer blocks: 1156601
Depends on: 1206879
Blocks: 1264965
Depends on: 1275876
Whiteboard: Heuristics-Recipes:passwords → [passwords:heuristics]
Depends on: 1287202
Blocks: 1289947
Depends on: 1291060
You need to log in before you can comment on or make changes to this bug.