MediaFormatReader should drain its decoder when encountering waiting for data error

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 affected, firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When the MediaFormatReader attempt to demux a frame, but the demuxer returns WAITING_FOR_DATA, it rejects the promise and enter wait mode (giving the MDSM a WaitingPromise).

It should attempt to drain the decoder first prior to rejecting the promise as there may be queued decoded frames ready to be output by the decoder.
(Assignee)

Comment 1

3 years ago
Blocking bug 1171379, as if we don't drain, the waiting event will be fired on a different time than what test_WaitingOnMissingData_mp4.html expects.
Blocks: 1171379
(Assignee)

Updated

3 years ago
See Also: → bug 1182985
(Assignee)

Comment 2

3 years ago
Created attachment 8632684 [details] [diff] [review]
Drain decoder when discontinuity encountered.

A discontinuity can be when waiting for data, decoding error or reaching end of stream.
Attachment #8632684 - Flags: review?(cpearce)
Attachment #8632684 - Flags: review?(cpearce) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → jyavenard
https://hg.mozilla.org/mozilla-central/rev/80f9da7f0806
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Comment 5

3 years ago
This is what's causing bug 1180935.
Blocks: 1180935
You need to log in before you can comment on or make changes to this bug.