MediaFormatReader should drain its decoder when encountering waiting for data error

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 affected, firefox42 fixed)

Details

Attachments

(1 attachment)

When the MediaFormatReader attempt to demux a frame, but the demuxer returns WAITING_FOR_DATA, it rejects the promise and enter wait mode (giving the MDSM a WaitingPromise).

It should attempt to drain the decoder first prior to rejecting the promise as there may be queued decoded frames ready to be output by the decoder.
Blocking bug 1171379, as if we don't drain, the waiting event will be fired on a different time than what test_WaitingOnMissingData_mp4.html expects.
Blocks: 1171379
See Also: → 1182985
A discontinuity can be when waiting for data, decoding error or reaching end of stream.
Attachment #8632684 - Flags: review?(cpearce)
Attachment #8632684 - Flags: review?(cpearce) → review+
Assignee: nobody → jyavenard
https://hg.mozilla.org/mozilla-central/rev/80f9da7f0806
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
This is what's causing bug 1180935.
Blocks: 1180935
You need to log in before you can comment on or make changes to this bug.