Closed Bug 1173978 Opened 5 years ago Closed 5 years ago

[JIT View] Only count optimization sites for youngest frames

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8621305 [details] [diff] [review]
1173978-jit-leaves.patch

Review of attachment 8621305 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for writing the test, it's gross.

::: browser/devtools/performance/modules/logic/jit.js
@@ +220,5 @@
> +
> +  get length() {
> +    return this.optimizationSites.length;
> +  }
> +};

What's this used for?

::: browser/devtools/performance/modules/logic/tree-model.js
@@ +239,3 @@
>          }
>          frameNode.samples++;
> +

Nit: remove empty line.
Attachment #8621305 - Flags: review?(shu) → review+
Comment on attachment 8621305 [details] [diff] [review]
1173978-jit-leaves.patch

Review of attachment 8621305 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/logic/jit.js
@@ +220,5 @@
> +
> +  get length() {
> +    return this.optimizationSites.length;
> +  }
> +};

Tests; makes JITOptimizations act like a collection with length/iterator capabilities
Moved the test to overlap test_tree-model-06.js and expand it a bit, as they were both covering close to the same thing, so consolidated them.

 https://hg.mozilla.org/integration/fx-team/rev/6fa8f466c01c
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/6fa8f466c01c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.