1173978 - [JIT View] Only count optimization sites for youngest frames

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1173978-jit-leaves.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c80e8191b3c

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 8621305 [details] [diff] [review]
1173978-jit-leaves.patch

Review of attachment 8621305 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for writing the test, it's gross.

::: browser/devtools/performance/modules/logic/jit.js
@@ +220,5 @@
> +
> +  get length() {
> +    return this.optimizationSites.length;
> +  }
> +};

What's this used for?

::: browser/devtools/performance/modules/logic/tree-model.js
@@ +239,3 @@
>          }
>          frameNode.samples++;
> +

Nit: remove empty line.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8621305 [details] [diff] [review]
1173978-jit-leaves.patch

Review of attachment 8621305 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/modules/logic/jit.js
@@ +220,5 @@
> +
> +  get length() {
> +    return this.optimizationSites.length;
> +  }
> +};

Tests; makes JITOptimizations act like a collection with length/iterator capabilities

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Moved the test to overlap test_tree-model-06.js and expand it a bit, as they were both covering close to the same thing, so consolidated them.

 https://hg.mozilla.org/integration/fx-team/rev/6fa8f466c01c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6fa8f466c01c