1174122 - Update the URL bar autocomplete popup's star icon so it is visible within selected items

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

from bug 1173746 comment 4:

> [...] you basically can't
> see the (dark blue) star for bookmarked autocomplete items with the default
> windows highlight color that we now use? I suppose this is why it used to be
> yellow [...] it was
> obviously already an issue for winxp luna, classic, and some high contrast
> themes (though we don't seem to have picked up on it) but we might still
> want to fix it in our win10 polish project now that it applies to win8 and
> win10 as well,

Comment 1

[Dão Gottwald [:dao]]

needinfo for the image

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Can we just use the same image as on OS X?
IIRC it's a completely white star as well. Not sure if the outline/proportions are any different, but I'd be surprised if they were...

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: bookmark-win10.png

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 5

[Dão Gottwald [:dao]]

Looking at the existing bookmark-XP.png and bookmark.png... Both have an embossed look, whereas the new one doesn't. Is this a deliberate difference or can we get rid of one or both of the older variants (while still making sure we use the white star for selected items depending on the OS, obviously)?

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to Dão Gottwald [:dao] from comment #5)
> Looking at the existing bookmark-XP.png and bookmark.png... Both have an
> embossed look, whereas the new one doesn't. Is this a deliberate difference
> or can we get rid of one or both of the older variants (while still making
> sure we use the white star for selected items depending on the OS,
> obviously)?

The difference is deliberate. I am not actually sure if we are using the first image of the sprite anywhere. The same icon lives in Toolbar.png. If it isn't used we could remove it entirely and just have the blue and inverted in this sprite.

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 9

[Dão Gottwald [:dao]]

Attachment: patch

another typo *sigh*

Comment 10

[Dão Gottwald [:dao]]

Attachment: patch

Comment 11

[:Gijs (he/him)]

Comment on attachment 8631746 [details] [diff] [review]
patch

Review of attachment 8631746 [details] [diff] [review]:
-----------------------------------------------------------------

I take it we don't mind winxp hidpi getting the win8/win10 star?

Also, the bookmarks button on the bookmarks toolbar on win8 needs margin/padding love. :-(

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/56ae687cc98a

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56ae687cc98a

Comment 14

[Andrei Vaida [:avaida]]

Reproduced the bug with Aurora 41.0a2 (2015-07-28).

This is verified fixed on Nightly 42.0a1 (2015-07-28), using Windows 10 Pro x64 (Build 10240).