Stacked Mountain Chart Widget

RESOLVED FIXED in Firefox 41

Status

RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: jsantell, Assigned: vporof)

Tracking

(Blocks: 1 bug)

41 Branch
Firefox 41
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

For mapping optimization tiers of frames over time.
(Reporter)

Updated

3 years ago
Blocks: 1150299
(Reporter)

Updated

3 years ago
Blocks: 1174267
We discussed this being a stacked mountain chart[0]. The most important thing to convey for JIT optimizations over time is hotness over time (% of samples in a range that the selected frame is executed out of total samples in a range), and what tier, if any, the frame settled in. While stacked mountain graphs do not easily show which group is greater, and can be visually ambiguous, this in itself conveys that there is not one obvious tier the sample was found in. Additionally, with the "hotness" conveying total samples observed that the frame was the leaf, aggregating the count regardless of tier, this shows which areas it matters that the tier settles into ion.

The data source expected for this is [{ x: time, ys: [percentage, percentage, percentage] }, ...], with each percentage (0-100? 0-1?) representing the peak of a group for that bucket. Bucket/windowing conversion from sample data to plottable data is handled in bug 1174889.

[0] http://2.bp.blogspot.com/_D9-JNTtRKgs/TC9RiVb3tMI/AAAAAAAABEE/ES1tv8H8R6k/s1600/Picture+165.png
(Reporter)

Updated

3 years ago
Status: NEW → ASSIGNED
Summary: LineGraphWidget should be able to handle multiple lines → Stacked Mountain Chart Widget
(Reporter)

Updated

3 years ago
No longer blocks: 1174267
(Assignee)

Comment 2

3 years ago
Created attachment 8624407 [details] [diff] [review]
v1
Attachment #8624407 - Flags: review?(jsantell)
Comment on attachment 8624407 [details] [diff] [review]
v1

Review of attachment 8624407 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good -- should make a followup bug for a bit more comprehensive test and `setTheme`
Attachment #8624407 - Flags: review?(jsantell) → review+
(Assignee)

Updated

3 years ago
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/84df534bc80e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.