Closed Bug 1174444 Opened 10 years ago Closed 10 years ago

[Settings] Convert screen lock switches to use gaia-switch

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

[Pull Request] Convert screen lock switches to use gaia-switch
46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review
This is initial work to eventually use web components everywhere.
Comment on attachment 8621998 [details] [review] [Pull Request] Convert screen lock switches to use gaia-switch Arthur or Evelyn - not sure who's still available for some settings app reviews, could either of you look at this? Or if you could point me to someone that would be great too. Thanks!
Attachment #8621998 - Flags: review?(ehung)
Attachment #8621998 - Flags: review?(arthur.chen)
Comment on attachment 8621998 [details] [review] [Pull Request] Convert screen lock switches to use gaia-switch r=me with the comment addressed, thanks!
Attachment #8621998 - Flags: review?(ehung)
Attachment #8621998 - Flags: review?(arthur.chen)
Attachment #8621998 - Flags: review+
Thank you for the review Arthur. Landed in master: https://github.com/mozilla-b2g/gaia/commit/4dfe2da502e4370c9670d5bc13a73d22fb37a785
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: