Closed Bug 1174563 Opened 10 years ago Closed 8 years ago

Loop and Pocket both contain a copy of jquery

Categories

(Firefox :: General, defect)

38 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
platform-rel --- -

People

(Reporter: glandium, Unassigned)

Details

(Whiteboard: [platform-rel-jQuery])

We're shipping two copies of jquery, one from loop, and the other from pocket. We should factor those and only ship one. (none would actually be even better). Also note that we minify javascript at packaging time, so we also shouldn't need to have them minified in the tree.
Blocks: fatfennec
Re Bug 942609 -- the Pocket one doesn't/shouldn't ship in Fennec at all. As far as I can tell, it's in browser/components/pocket/panels/js/vendor/jquery-2.1.1.min.js and browser is desktop-only, so that's OK, and thus this doesn't block Bug 942609. nfroyd, am I missing something? (For that matter I don't believe we ship browser/components/loop in Fennec, either, so…)
Flags: needinfo?(nfroyd)
(In reply to Richard Newman [:rnewman] from comment #1) > Re Bug 942609 -- the Pocket one doesn't/shouldn't ship in Fennec at all. > > As far as I can tell, it's in > > browser/components/pocket/panels/js/vendor/jquery-2.1.1.min.js > > and browser is desktop-only, so that's OK, and thus this doesn't block Bug > 942609. nfroyd, am I missing something? Nope!
No longer blocks: fatfennec
Flags: needinfo?(nfroyd)
The files are: browser/components/loop/content/shared/libs/jquery-2.1.4.js browser/components/pocket/panels/js/vendor/jquery-2.1.1.min.js browser/components/pocket/panels/js/vendor/jquery.tokeninput.min.js
Oops, please ignore the tokeninput file.
(In reply to Mike Hommey [:glandium] from comment #0) > Also note that we minify javascript at packaging time, so we also shouldn't > need to have them minified in the tree. I don't think this is actually the case? Did I miss a memo?
(In reply to :Gijs Kruitbosch from comment #5) > (In reply to Mike Hommey [:glandium] from comment #0) > > Also note that we minify javascript at packaging time, so we also shouldn't > > need to have them minified in the tree. > > I don't think this is actually the case? Did I miss a memo? If I am searching the right thing (MOZ_PACKAGER_MINIFY_JS), it's enabled for Firefox OS and Fennec, but not desktop Firefox.
Whiteboard: [platform-rel-jQuery]
platform-rel: --- → ?
platform-rel: ? → -
Fixed by bug 1287827 until Mozilla's next whim brings back yet another copy of jQuery.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.