Closed Bug 1174569 Opened 5 years ago Closed 3 years ago

[css-grid] Implement the Grid Sizing Algorithm

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox41 --- affected
firefox50 --- fixed

People

(Reporter: mats, Assigned: mats)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

Attachments

(1 file)

Blocks: 1194446
Blocks: 1217086
Duplicate of this bug: 1272783
Blocks: 1233218
Blocks: 1222724
I think this is good enough to implement Step 2 in the spec algorithm.
It actually fixes all of the testcases in the dependent bugs.

I'd like to land this for now so that people don't stumble on this
and can continue to find more bugs and differences we have compared
to other UAs.
Attachment #8761857 - Flags: review?(dholbert)
Comment on attachment 8761857 [details] [diff] [review]
Use the resolved column sizes to guide intrinsic row sizing.

Review of attachment 8761857 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.  Sorry for the delay!  r=me
Attachment #8761857 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c719d640442b
[css-grid] Use the resolved column sizes to guide intrinsic row sizing.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/c719d640442b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Nice work!
Depends on: 1300366
"12.1. Grid Sizing Algorithm" is implemented for the most part, only step 3
is missing.  I filed bug 1300366 for the remaining work.
Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Flags: in-testsuite+
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.