Closed
Bug 1217086
Opened 9 years ago
Closed 8 years ago
[css-grid] Enable CSS Grid by default
Categories
(Core :: Layout, enhancement, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, DevAdvocacy, Whiteboard: [DevRel:P1])
Attachments
(1 file)
2.03 KB,
patch
|
dholbert
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
At the same time we should also remove:
https://hg.mozilla.org/mozilla-central/diff/3038a5a34a75/testing/profiles/prefs_general.js
Updated•9 years ago
|
Severity: normal → enhancement
Assignee | ||
Updated•9 years ago
|
Updated•9 years ago
|
Keywords: DevAdvocacy
Updated•9 years ago
|
Whiteboard: [DevRel:P1]
Updated•9 years ago
|
Keywords: dev-doc-needed
Updated•9 years ago
|
Flags: platform-rel?
Updated•9 years ago
|
platform-rel: --- → ?
Updated•9 years ago
|
platform-rel: ? → ---
Aren't there any plans to include this into one of the nearest releases? The spec has already pretty stable (CR), isn't it time to ship it?
Comment 2•8 years ago
|
||
Mozilla is actively working on an implementation, but it is not finished yet. Please have a look at the bugs listed under "Depends on".
Sebastian
(In reply to Sebastian Zartner [:sebo] from comment #2)
> Please have a look at the bugs listed under "Depends on".
It seems that currently all bugs listed there are already resolved. Aren't there any news about shipping date of this feature? Web developers are so looking forward to it!)
JFI: Chrome team already has the Intent to ship Grid Layout (https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/hBx1ffTS9CQ/TMTigaDIAgAJ).
> The idea would be to switch the flag after M56 is branched.
Assignee | ||
Comment 5•8 years ago
|
||
We'll ship in Firefox 52:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/6shk3TZX5vo
https://wiki.mozilla.org/RapidRelease/Calendar
Assignee: nobody → mats
OS: Unspecified → All
Hardware: Unspecified → All
Target Milestone: --- → mozilla52
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8815027 -
Flags: review?(dholbert)
Updated•8 years ago
|
Attachment #8815027 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67cb3a752911
Enable CSS Grid by default. r=dholbert
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8815027 [details] [diff] [review]
fix
Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: this is required to ship CSS Grid
[Is this code covered by automated tests?] yes, plenty
[Has the fix been verified in Nightly? not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: it's enabled in Nightly/Aurora already; this patch makes it ride the trains to Beta/Release
[String changes made/needed]: none
Attachment #8815027 -
Flags: approval-mozilla-aurora?
Comment 9•8 years ago
|
||
bugherder |
Comment 10•8 years ago
|
||
Comment on attachment 8815027 [details] [diff] [review]
fix
css grid feature for 52 release
Attachment #8815027 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•8 years ago
|
||
bugherder uplift |
status-firefox52:
--- → fixed
Flags: in-testsuite+
Comment 12•8 years ago
|
||
I have seen this bug with Nightly 44.0a1 (2015-10-21) on WIndows 7, 64 Bit , which is "enabling CSS Grid by default" and I have seen the feature implemented in latest Beta and latest Developer Edition(Aurora)!
Build ID : 20170220070057
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID : 20170221004019
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
[bugday-20170222]
Comment 13•8 years ago
|
||
MDN docs:
The different compatibility tables in the articles have been updated.
There is a mention in https://developer.mozilla.org/en-US/Firefox/Releases/52#CSS_Grids
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•