1174650 - [RTL][Utility Tray]The position of icons at utility-tray is mirrored.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Sue]

Attachment: utility tray.png

[1.Description]:
[RTL][Flame 3.0][Nexus5 3.0][Utility Tray]The position of icons(Settings, Wi-Fi, Bluetooth and so on) at utility-tray is mirrored in RTL.
See attachment:utility tray.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic.
1. Pull down the notification bar.
2. Observe the icons at utility-tray.

[3.Expected Result]: 
2. Icons should remain the same position as that in LTR.

[4.Actual Result]: 
2. The position of icons is mirrored.

[5.Reproduction build]: 
Device: Flame 2.2 (unaffected)
Build ID               20150614002504
Gaia Revision          cfceba16e48ede3defee24be93637a0fa291c494
Gaia Date              2015-06-11 22:10:18
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2cfd86c2ba1b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150614.040237
Firmware Date          Sun Jun 14 04:02:49 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150614010203
Gaia Revision          1bf2da102560481748ff3f6202fbed5c4daa5832
Gaia Date              2015-06-13 00:22:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c223b8844264
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150614.044513
Firmware Date          Sun Jun 14 04:45:25 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (unaffected)
Build ID               20150614002504
Gaia Revision          cfceba16e48ede3defee24be93637a0fa291c494
Gaia Date              2015-06-11 22:10:18
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2cfd86c2ba1b
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150614.042607
Firmware Date          Sun Jun 14 04:26:25 EDT 2015
Bootloader             HHZ12d

Device: Nexus 5 3.0 (affected)
Build ID               20150614010203
Gaia Revision          1bf2da102560481748ff3f6202fbed5c4daa5832
Gaia Date              2015-06-13 00:22:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c223b8844264
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150614.044149
Firmware Date          Sun Jun 14 04:42:08 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Gregor Wagner [:gwagner]]

Delphine, is this something we want anyways?

Comment 2

[Sue]

B2G-Inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
Build ID               20150612070055
Gaia Revision          9be8b8637a3cc5ed52aa12838d864bef2f460122
Gaia Date              2015-06-12 13:30:07
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/54187b1fdce2
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150615.191939
Firmware Date          Mon Jun 15 19:19:48 EDT 2015
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Device: Flame 3.0
Build ID               20150612070755
Gaia Revision          26f74fb58e573616912ddbc11464f88e33afea63
Gaia Date              2015-06-12 13:45:08
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/df9260369037
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150615.040806
Firmware Date          Mon Jun 15 04:08:18 EDT 2015
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia: 26f74fb58e573616912ddbc11464f88e33afea63
Gecko: 54187b1fdce2

First Broken Gecko & Last Working Gaia - issue dose NOT repro
Gaia: 9be8b8637a3cc5ed52aa12838d864bef2f460122
Gecko: df9260369037

b2g-inbound pushlog:
https://github.com/mozilla-b2g/gaia/compare/9be8b8637a3cc5ed52aa12838d864bef2f460122...26f74fb58e573616912ddbc11464f88e33afea63

This might have been caused by Bug 1173836

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

As mentioned to QA, we have no idea what the 3.0 specs for RTL are at this point. Unless I'm mistaken? Flagging FirefoxOS UX team for confirmation, as per my talk with Stephany right before she left.
From what I understand, the only thing we can know for sure at this point is where LTR vs RTL truncation should appear.

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Added to 2.5 systems RTL meta. Please close bug as resolved invalid if 2.5 RTL UX specs state that this should look this way. thanks

Comment 5

[Tiffanie Shakespeare [:tif]]

According to the spec toolbars are not mirror, let's consider this a toolbar and should therefore not be mirrored. 

Thanks and sorry for the delay!

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Specs for 2.5 weren't there yet when Tiffanie replied.
I looked at the 2.0M specs (still need some updating, but this part shouldn't change) and it still states icons should not be mirrored. This is therefore a valid bug

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:
Nominating as this is a regression from 2.2 and is contrary to RTL expected behavior on 2.5

Comment 8

[Gregor Wagner [:gwagner]]

Sam, can you check with 2.5 UX spec?

Comment 9

[Sam Foster [:sfoster] (he/him)]

(In reply to Gregor Wagner [:gwagner] from comment #8)
> Sam, can you check with 2.5 UX spec?

I don't have any more info than Delphine on this (comment #6). See bug 1179459 - the 2.5 RTL spec does not yet exist, but we expect it to resemble v2.0m, so this stands as a valid bug. We'll get the update spec posted somewhere for reference as soon as we have it.

Comment 10

[Gregor Wagner [:gwagner]]

Thanks Sam.
Wilson, seems like you are the lucky one here :)

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1174650 > mozilla-b2g:master

Comment 12

[Guillaume Marty [:gmarty]]

Comment on attachment 8645685 [details] [review]
[gaia] wilsonpage:1174650 > mozilla-b2g:master

Looks good to me. Thanks Wilson and Flexbox :-)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/cb5030c587624101723123f0de700a4a69c1bac2

Comment 14

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: verified fixed screenshot

This issue is verified fixed on central. When in Arabic, the utility tray toolbar icons are not mirrored. See attached screenshot on current behavior.

Device: Aries 2.6 Master
BuildID: 20151112122058
Gaia: 27bc9412ca607648bc398b25bb1ae25653b2b278
Gecko: 3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Flame 2.6 Master
BuildID: 20151112030244
Gaia: 27bc9412ca607648bc398b25bb1ae25653b2b278
Gecko: 3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 15

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's get this verified on 2.5 as well.

Comment 16

[zouyi(Leave from Mozilla)]

This bug has been verified as pass on latest build of Flame KK v2.5 512mb and Aries KK v2.5 by the STR in Comment 0. 

Actual result: Icons remain the same position as that in LTR of the notification bar.

See attachment: Verified Aries_KK v2.5.png

Reproduce rate: 0/10

Device: Flame KK v2.5 512mb (Pass)
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version        V18D V4
Bootloader             L1TC000118D0

Device: Aries KK v2.5(Pass) 
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1

Comment 17

[zouyi(Leave from Mozilla)]

Attachment: Verified Aries_KK v2.5.png