Closed Bug 1174673 Opened 9 years ago Closed 9 years ago

[RIL] Automatically resume a remaining held call or held conference

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2+, firefox40 wontfix, firefox41 wontfix, firefox42 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S2 (10Jul)
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
firefox40 --- wontfix
firefox41 --- wontfix
firefox42 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: hsinyi, Assigned: aknow)

References

Details

Attachments

(4 files)

Part 1: Automatically resume the held call
1.33 KB, patch
hsinyi
: review+
Details | Diff | Splinter Review
Part 2: Update test case
1.25 KB, patch
hsinyi
: review+
Details | Diff | Splinter Review
(2.2) Part 1: Automatically resume the held call. r=hsinyi
1.66 KB, patch
hsinyi
: review+
jocheng
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
(2.2) Part 2: Update test case. r=hsinyi
1.26 KB, patch
aknow
: review+
jocheng
: approval-mozilla-b2g37+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 1169409
Hi Aknow, Could you please help this bug?
Flags: needinfo?(szchen)
Nominate this as 2.2+ as this blocks a 2.2+ gaia bug 1169409.
blocking-b2g: --- → 2.2?
Flags: needinfo?(szchen)
QA Contact: szchen
Assignee: nobody → szchen
QA Contact: szchen
Summary: [RIL] Automatically resume a remaining held call → [RIL] Automatically resume a remaining held call or held conference
blocking-b2g: 2.2? → 2.2+
status-b2g-v2.2: --- → affected

        Attachment #8624144 -
        Flags: review?(htsai)

    
    

    
  
Comment on attachment 8624142 [details] [diff] [review]
Part 1: Automatically resume the held call

Review of attachment 8624142 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Aknow.

        Attachment #8624142 -
        Flags: review?(htsai) → review+

    
  

        Attachment #8624144 -
        Flags: review?(htsai) → review+

    
    

    
  
Please nominate this for b2g37 approval when you get a chance.

          status-b2g-v2.5:
          --- → fixed

          status-b2g-master:
          --- → fixed

          status-firefox40:
          --- → wontfix

          status-firefox41:
          --- → wontfix
Flags: needinfo?(szchen)
Target Milestone: --- → FxOS-S2 (10Jul)

    
    

    
  


  
Hsinyi,
Due to the difference of code bases, I'd like to have your review again. Thank you.
Flags: needinfo?(szchen)

        Attachment #8628696 -
        Flags: review?(htsai)

    
  

        Attachment #8628697 -
        Attachment description: Part 2: Update test case. r=hsinyi → (2.2) Part 2: Update test case. r=hsinyi

    
  
Flags: needinfo?(szchen)

    
    

    
  
Comment on attachment 8628696 [details] [diff] [review]
(2.2) Part 1: Automatically resume the held call. r=hsinyi

Review of attachment 8628696 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

        Attachment #8628696 -
        Flags: review?(htsai) → review+

    
    

    
  
Comment on attachment 8628696 [details] [diff] [review]
(2.2) Part 1: Automatically resume the held call. r=hsinyi

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1169409 
User impact if declined: gcf test fail
Testing completed: marionette unit test
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none
Flags: needinfo?(szchen)

        Attachment #8628696 -
        Flags: approval-mozilla-b2g37?

    
    

    
  
Comment on attachment 8628697 [details] [diff] [review]
(2.2) Part 2: Update test case. r=hsinyi

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1169409 
User impact if declined: gcf test fail
Testing completed: marionette unit test
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

        Attachment #8628697 -
        Flags: approval-mozilla-b2g37?

    
  

        Attachment #8628696 -
        Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+

    
  

        Attachment #8628697 -
        Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: