Closed Bug 1174845 Opened 6 years ago Closed 6 years ago

Remove purple overflow menu button

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox41 verified, firefox42 verified)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- verified
firefox42 --- verified

People

(Reporter: antlam, Assigned: mhaigh)

References

Details

Attachments

(1 file)

We can save the extra asset here and just use the same one from the normal browsing toolbar... It also looks better I think!
Flags: needinfo?(mhaigh)
Blocks: fatfennec
Flags: needinfo?(mhaigh)
Attachment #8623065 - Flags: review?(michael.l.comella)
Assignee: nobody → mhaigh
Comment on attachment 8623065 [details] [diff] [review]
Remove purple overflow menu button

Review of attachment 8623065 [details] [diff] [review]:
-----------------------------------------------------------------

We should be able to remove menuIcon.setPrivateMode(isPrivate); [1] now, right?

I wonder when we used the maxLevel=2 level-list item (hardware menu button, perhaps?).

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#839
Attachment #8623065 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/3ad027df2594
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Menu button in private browsing is grey, so verified fixed using:
Device: Nexus 4 (Android 5.0)
Builds: Firefox for Android 41.0a2 (2015-07-16) and Firefox for Android 42.0a1 (2015-07-16)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.