1174845 - Remove purple overflow menu button

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

We can save the extra asset here and just use the same one from the normal browsing toolbar... It also looks better I think!

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Remove purple overflow menu button

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8623065 [details] [diff] [review]
Remove purple overflow menu button

Review of attachment 8623065 [details] [diff] [review]:
-----------------------------------------------------------------

We should be able to remove menuIcon.setPrivateMode(isPrivate); [1] now, right?

I wonder when we used the maxLevel=2 level-list item (hardware menu button, perhaps?).

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#839

Comment 3

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/3ad027df2594

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3ad027df2594

Comment 5

[Teodora Vermesan (:TeoVermesan)]

Menu button in private browsing is grey, so verified fixed using:
Device: Nexus 4 (Android 5.0)
Builds: Firefox for Android 41.0a2 (2015-07-16) and Firefox for Android 42.0a1 (2015-07-16)