nsDisplayListInvalidation.cpp doesn't compile in non-unified mode (or if it's the first file in a unified group)
RESOLVED
FIXED
in Firefox 41
Status
()
People
(Reporter: kats, Assigned: kats)
Tracking
Firefox Tracking Flags
(firefox41 fixed)
Details
Attachments
(1 attachment)
1.02 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
I added a file to layout/base and now nsDisplayListInvalidation.cpp doesn't compile. The error: /builds/slave/try-lx-d-000000000000000000000/build/src/layout/base/nsDisplayListInvalidation.cpp:130:50: error: no matching function for call to 'nsDisplayItemGenericGeometry::nsDisplayItemGenericGeometry(nsDisplayTableItem*&, nsDisplayListBuilder*&)' /builds/slave/try-lx-d-000000000000000000000/build/src/layout/base/nsDisplayListInvalidation.cpp:130:50: error: no matching function for call to 'nsImageGeometryMixin<nsDisplayTableItemGeometry>::nsImageGeometryMixin(nsDisplayTableItem*&, nsDisplayListBuilder*&)' It looks like in nsDisplayListInvalidation.cpp, the compiler doesn't know that nsDisplayTableItem is a subclass of nsDisplayItem, and so can't convert the nsDisplayTableItem* to a nsDisplayItem*.
(Assignee) | ||
Comment 1•4 years ago
|
||
Seems like this was added in bug 1082249 not too long ago. Even though nsTableFrame.h doesn't seem to be exported in layout/tables/moz.build including nsTableFrame.h seems to fix it locally. Doing a clean build to verify first.
Blocks: 1082249
(Assignee) | ||
Comment 2•4 years ago
|
||
Created attachment 8623200 [details] [diff] [review] Patch
Attachment #8623200 -
Flags: review?(mstange)
Updated•4 years ago
|
Attachment #8623200 -
Flags: review?(mstange) → review+
Comment 4•4 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f1467e2f65c2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•