1175217 - nsDisplayListInvalidation.cpp doesn't compile in non-unified mode (or if it's the first file in a unified group)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

I added a file to layout/base and now nsDisplayListInvalidation.cpp doesn't compile. The error:


/builds/slave/try-lx-d-000000000000000000000/build/src/layout/base/nsDisplayListInvalidation.cpp:130:50: error: no matching function for call to 'nsDisplayItemGenericGeometry::nsDisplayItemGenericGeometry(nsDisplayTableItem*&, nsDisplayListBuilder*&)'
/builds/slave/try-lx-d-000000000000000000000/build/src/layout/base/nsDisplayListInvalidation.cpp:130:50: error: no matching function for call to 'nsImageGeometryMixin<nsDisplayTableItemGeometry>::nsImageGeometryMixin(nsDisplayTableItem*&, nsDisplayListBuilder*&)' 

It looks like in nsDisplayListInvalidation.cpp, the compiler doesn't know that nsDisplayTableItem is a subclass of nsDisplayItem, and so can't convert the nsDisplayTableItem* to a nsDisplayItem*.

Comment 1

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Seems like this was added in bug 1082249 not too long ago. Even though nsTableFrame.h doesn't seem to be exported in layout/tables/moz.build including nsTableFrame.h seems to fix it locally. Doing a clean build to verify first.

Comment 2

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Attachment: Patch

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1467e2f65c2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f1467e2f65c2