Enable dynamic UA overrides in Fennec (general.useragent.updates.enabled -> true)

RESOLVED FIXED in Firefox 41

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: miketaylr, Assigned: miketaylr)

Tracking

unspecified
Firefox 41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(p11+, firefox41 fixed, fennec41+)

Details

(Whiteboard: [compat])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Now that Bug 1163759 is complete, we need to flip the pref to enable UA override updates.

I'd like Bug 1174784 to land first though, so we don't break Youtube when Bug 1169772 lands.
(Assignee)

Updated

3 years ago
Assignee: nobody → miket
Blocks: 1169772
tracking-p11: --- → +
Depends on: 1174784
Whiteboard: [compat]
(Assignee)

Updated

3 years ago
Depends on: 1175301
No longer depends on: 1174784
(Assignee)

Updated

3 years ago
tracking-fennec: --- → ?
(Assignee)

Comment 1

3 years ago
Created attachment 8623740 [details] [diff] [review]
1175305-Enable-dynamic-UA-updates-for-Fennec.patch

Margaret, would you mind reviewing? 

I've tested that this does in fact talk to our CDN endpoint (https://dynamicua.cdn.mozilla.net/0/%7Baa3c5121-dab2-40e2-81ca-7ea25febc110%7D) and fetches the payload as expected.
tracking-fennec: ? → 41+

Comment 2

3 years ago
Comment on attachment 8623740 [details] [diff] [review]
1175305-Enable-dynamic-UA-updates-for-Fennec.patch

Review of attachment 8623740 [details] [diff] [review]:
-----------------------------------------------------------------

r+, assuming dependencies land first as needed.
Attachment #8623740 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8624493 [details] [diff] [review]
1175305-Enable-dynamic-UA-updates-for-Fennec.patch

Updating commit message to reflect r=margaret.
(Assignee)

Updated

3 years ago
Attachment #8623740 - Attachment is obsolete: true
(Assignee)

Comment 4

3 years ago
Sheriffs, no try run because this changeset just flips an existing pref to true (and manual testing looks good).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/07b5f3ee0315
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
(Assignee)

Updated

3 years ago
See Also: → bug 1184268
You need to log in before you can comment on or make changes to this bug.