1184268 - Re-enable dynamic UA updates (general.useragent.updates.enabled -> true)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Taylor [:miketaylr]]

Bug 1178760 fixes the bug where UserAgentUpdates.jsm couldn't get to the ua-update.json in the APK root.

This bug will re-enable the pref (as well as get rid of the now redundant Youtube override).

Comment 1

[Mike Taylor [:miketaylr]]

Attachment: 1184268-Remove-Youtube-override-pref-covered-by-.patch

Comment 2

[Mike Taylor [:miketaylr]]

Attachment: 1184268-Flip-useragent.updates.enabled-pref-to-t.patch

I've built and tested these patches (with patch from Bug 1178760) and Youtube continues to work--which means the override from ua-update.json is working again.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8634312 [details] [diff] [review]
1184268-Flip-useragent.updates.enabled-pref-to-t.patch

Review of attachment 8634312 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, assuming bug 1178760 lands first :)

Comment 4

[Mike Taylor [:miketaylr]]

The patch for 1178760 is already on fx-team, so it's safe to check-in here.

Sheriffs, no try run--just flipping a pref and removing another. Built + tested locally.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/af5f619da58e
https://hg.mozilla.org/integration/fx-team/rev/8ae76d6f285f

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/af5f619da58e
https://hg.mozilla.org/mozilla-central/rev/8ae76d6f285f