1175361 - add partition fix to the flame-kk builds

Status: RESOLVED WONTFIX

(Taskcluster :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

see https://bugzilla.mozilla.org/show_bug.cgi?id=1085230#c12

This fixes issues with OTA.

I am not sure if Taskcluster is capable of adding additional partitions and having a change to the flash.sh script.

I am willing to help out to make the changes for the pvtbuilds.

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
This blocks a smoke test case and creates a blocker.

Comment 2

[Greg Arndt [:garndt]]

Wander, is this something that's needed on the build script side? This isn't taskcluster specific, but I'm not sure how the phone images get created with the partitions

Comment 3

[Wander Lairson Costa]

(In reply to Greg Arndt [:garndt] from comment #2)
> Wander, is this something that's needed on the build script side? This isn't
> taskcluster specific, but I'm not sure how the phone images get created with
> the partitions

/me <--- deadlock
I have no idea how this work, I guess this is done inside mozharness or in the B2G build system. I will investigate and let you know. I am going to keep NI on me to not forget this.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

garndt, wcosta:
1) We need the flame.zip file to include gpt_both0_big.bin from bug 1085230.
2) Then we need to change the flash script to include : 
fastboot flash partition gpt_both0_big.bin

Comment 5

[Wander Lairson Costa]

Naoki,

Any clue where the flashboot command fits inside flash.sh script?

Comment 6

[Greg Arndt [:garndt]]

Removing ni? , Wander has the best context on this and this is not a taskcluster platform specific issue I don't believe.

Comment 7

[Wander Lairson Costa]

I already have patches for this (somewhere), I only need to know the context of the adb command inside flash.sh, this is the last piece.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's done by fastboot not adb:
fastboot flash partition gpt_both0_big.bin

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

The flash script that's associated with the zip file needs to be updated to have that line.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think we need the flash blob to contain the partition fix as well.  I'm not sure how the blob images are put together for the zip file.  Pinging jonasjf for that support/info.

Comment 11

[Jonas Finnemann Jensen (:jonasfj)]

:nhirata,
I'm sorry to say I have little clue what this is about. I have no idea about the build system.
This seems like something that happens inside the task, so you'll probably have to look at the
docker image (I suspect quay.io/mozilla/phone-builder) or whatever scripts it runs from the tree.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think the docker image has to include the partition resize file, an edit to the flash script and a recoding of the zipping to include the partition resize file...

- OR - 

we replace the partition resize file in the docker image.  ie mv gpt_both0_big.bin gpt_both0.bin

Otherwise we would be relying on the base image to fix the issue, and we would have to make sure that whoever flashes these images use the base build image first and then flash a build.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Since we're doing FOTA now, it appears that we don't need this change to occur.
The base build should include the fix.