1175378 - Audit /mobile/android/themes/core/images for unused images

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Already I see at least addons-32.png, not sure if there are more.

Comment 1

[Mike Taylor [:miketaylr]]

I just did this using DXR. Here are the images that only have references in mobile/android/themes/core/jar.mn and nowhere else:

addons-32.png, 2kb
arrowleft-16.png, 143b
arrowright-16.png, 144b
default-app-icon.png, 3kb
errorpage-larry-black.png, 564b
errorpage-larry-white.png, 562b

Comment 2

[Mike Taylor [:miketaylr]]

Attachment: 1175378.-Remove-unused-image-assets.-r-margaret.patch

Mind reviewing, Margaret?

Builds locally without complaining, not sure if I should throw this patch at Try.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8649625 [details] [diff] [review]
1175378.-Remove-unused-image-assets.-r-margaret.patch

Some digging reveals:
* default-app-icon.png was added in bug 749618 for aboutApps, which is gone
* errorpage-larry-*.png was added in bug 582048 for making the error pages look nicer. those have been modified a lot since then.
* arrow*-16.png files are ancient too.

Comment 4

[Mike Taylor [:miketaylr]]

RIP larry. ;_;

Comment 5

[:Margaret Leibovic]

Comment on attachment 8649625 [details] [diff] [review]
1175378.-Remove-unused-image-assets.-r-margaret.patch

Review of attachment 8649625 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for picking this up! Some quick searching verifies these aren't used anywhere, so I think we're good (I don't think a try run would necessarily catch problems with missing icons).

Comment 6

[Mike Taylor [:miketaylr]]

Thanks for the review!

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/a4e7c2672a64

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4e7c2672a64