1175536 - Zoomed View is displayed on the reader view toolbar

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-06-17-17-55-03.png

Steps to reproduce:
1. Go to news.google.com and choose an article
2. Enter reader view
3. Invoke reader view toolbar and tap the "Aa" button
4. Tap on the dialog

Expected results: 
- Nothing happens

Actual results:
- Zoomed view is displayed
- please look at the following video: https://youtu.be/w7MAg0WcXv4

Comment 1

[:Margaret Leibovic]

Here's the HTML for this page:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/content/aboutReader.html?force=1

I feel like this is a bug with the zoomed view logic, not something we should change specifically for reader view.

Comment 2

[Dominique Vincent [:domivinc]]

The zoomed view is displayed when the user taps on an area near 2 or more clickable elements.
Based on the html code, the dialog contains several "Button" elements. When the user taps between 2 buttons, this area is probably considered as a cluster of links.
I'm going to trace the cluster detection process to verify.

Comment 3

[Dominique Vincent [:domivinc]]

Attachment: readerViewButtonsAreas.png

Comment 4

[Dominique Vincent [:domivinc]]

Attachment: readerViewClustersAreas.png

Comment 5

[Dominique Vincent [:domivinc]]

Attachment: readerViewBug1.png

Comment 6

[Dominique Vincent [:domivinc]]

Attachment: readerViewBug2.png

The cluster detection seems to work correctly. On the first attached picture (readerViewButtonsAreas) you can see a border for each button of the reader view. In the second picture (readerViewClustersAreas), I added the different cluster areas in green. The zoomed view is displayed when the user taps in those areas.

I found a bug using the reader view toolbar/dialog if you didn’t scroll inside the main page. In this case, the url bar offset is probably not taken into account in the click position calculation. 
On the “Aa” button in the small reader view toolbar, if you click on top of the 2 letters, the toolbar is closed and not display the full reader view dialog. If you click below the 2 letters, it works correctly. 
There is the same calculation error, when the dialog is open, with all the buttons. If you click on top of “Sans-serif” or “Serif” text areas, the dialog is closed. And the font is not changed.
You can see the 2 areas where the error is visible in blue in readerViewBug1 and readerViewBug2 pictures.
As soon as vertical scroll is used in the page, the issues are no more visible.

Comment 7

[:Margaret Leibovic]

Thanks for looking into this. If I'm understanding this correctly, it sounds like the problem is that we should increase the touch target size for the reader view controls.

If someone is interested in picking this up, the place where we need to make the change is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReaderControls.css

Comment 8

[Dominique Vincent [:domivinc]]

(In reply to :Margaret Leibovic from comment #7)
> Thanks for looking into this. If I'm understanding this correctly, it sounds
> like the problem is that we should increase the touch target size for the
> reader view controls.
> 
No, the issue is not specific to the reader view controls. The issue is not in the zoomed view.
Working on another bug, I found that the issue is more global (in nightly). 
You can read the comment 2 (point 1) here [1] to see exactly the same strange behavior: you can click below a button ("log in" in the economist page) and the action "Log in" is done.
Using the production version of Firefox for Android, it works correctly, clicking below the button, nothing is done.
I can reproduce the issue using my device HTC, Android version 2.3. If you cannot reproduce the bug, it could be a bug specific to my version of Android.


[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1176453#c2

Comment 9

[:Margaret Leibovic]

(In reply to Dominique Vincent [:domivinc] from comment #8)
> (In reply to :Margaret Leibovic from comment #7)
> > Thanks for looking into this. If I'm understanding this correctly, it sounds
> > like the problem is that we should increase the touch target size for the
> > reader view controls.
> > 
> No, the issue is not specific to the reader view controls. The issue is not
> in the zoomed view.
> Working on another bug, I found that the issue is more global (in nightly). 
> You can read the comment 2 (point 1) here [1] to see exactly the same
> strange behavior: you can click below a button ("log in" in the economist
> page) and the action "Log in" is done.
> Using the production version of Firefox for Android, it works correctly,
> clicking below the button, nothing is done.
> I can reproduce the issue using my device HTC, Android version 2.3. If you
> cannot reproduce the bug, it could be a bug specific to my version of
> Android.
> 
> 
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1176453#c2

I'm afraid I don't understand this comment... are you suggesting that there's some platform regression here? Did your patch for bug 1176453 address this? I'm trying to understand what needs to happen in this bug.

Comment 10

[Dominique Vincent [:domivinc]]

No, my patch for bug 1176453 didn't fix that. 
On the video of the first comment, the tap probably occurs between 2 buttons of the reader view. In this case, the zoomed view is displayed because the position of the tap is in a cluster of links (2 clickable elements near the tap position). Nothing to fix in that case.

But on my device, I found that the tap position is not always correct. The issue is visible without the zoomed view, just with the "Aa" button. This tap position error could be the reason why clicking on the center of a button, the action is not done and the zoomed view is displayed. 

Could you try on your device the following steps:

1) Using a nightly build
https://www.youtube.com/watch?v=o0YTwg1sQbw
If you tap on the "Aa" button of the reader view, the reader dialog is not displayed. You can try several times, it never works.
After a scroll down in the main page, it works.

2) Using Firefox 39.0
https://www.youtube.com/watch?v=SqWzBSbermY
Using Firefox 39.0, the first tap on "Aa" nothing happens. The second time, the reader view dialog is displayed.

My device: HTC Desire Z Android 2.3.3, (I have to set : reader.parse-on-load.force-enabled = true).

Comment 11

[:Margaret Leibovic]

I think some of these tap issues might have been related to the various position: fixed; problems that are now resolved with the new dynamic toolbar work that kats recently landed (e.g. bug 975533).

I'm actually having trouble reproducing this problem now. Is this still an issue?

Comment 12

[Dominique Vincent [:domivinc]]

This issue is a "moving" issue.

Now, the tool bar is not on the bottom of the page. There is a blank area just after the tool bar. You have to scroll down to get it in the correct position:
https://youtu.be/qMD_IixH81g

And the search input field in about:config is no more accessible. As soon as you click on the search input field, the address bar is displayed. It's because the search input field should be displayed under the address bar:
https://youtu.be/U600-uGUr4k

Both issues are probably linked (invalid offset to display the different widgets over the page?).

Comment 13

[Dominique Vincent [:domivinc]]

Margaret, I just added a comment in bug 1137872 to inform Kats.
Without the fix in the new dynamic toolbar, it's not easy to test the zoomed view behavior in the tool bar because I  never know when the position reported is correct or not ...
You can close it. We will re-open it if we still see a zoomed view issue after the fix of the dynamic toolbar.

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Dominique, can you still reproduce this? It looks like the issues you outlined in bug 1137872 were taken care of in bug 1197811, according to bug 1137872 comment 9.

If not, can you close, worksforme? :)

Comment 15

[Dominique Vincent [:domivinc]]

(In reply to Michael Comella (:mcomella) from comment #14)
> Dominique, can you still reproduce this? It looks like the issues you
> outlined in bug 1137872 were taken care of in bug 1197811, according to bug
> 1137872 comment 9.
> 
> If not, can you close, worksforme? :)

The zoomed view is no more displayed using the reader tool bar.
Regarding the position of the reader tool bar, the issue is still visible. I added a screen copy of the issue in bug 1137872 comment 10.