Closed
Bug 1175566
Opened 9 years ago
Closed 9 years ago
Change menu_popup LinearLayout to FrameLayout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mcomella, Assigned: sergej, Mentored)
Details
(Whiteboard: [lang=java][good first bug])
Attachments
(1 file)
3.77 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
As Martyn pointed out in [1], only one View is ever added to the LinearLayout so using it is unnecessarily expensive. Change it to a FrameLayout!
To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android
Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches
If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Thanks and happy coding! ^_^
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1170884#c28
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8625827 -
Flags: review?(michael.l.comella)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → sergej
Reporter | ||
Comment 2•9 years ago
|
||
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8625827 [details] [diff] [review]
Change menu_popup LinearLayout to FrameLayout
Review of attachment 8625827 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch, sergej!
I made a push to our try test servers (above).
Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.
[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8625827 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•