1175566 - Change menu_popup LinearLayout to FrameLayout

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

As Martyn pointed out in [1], only one View is ever added to the LinearLayout so using it is unnecessarily expensive. Change it to a FrameLayout!

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1170884#c28

Comment 1

[Sergej Kravcenko]

Attachment: Change menu_popup LinearLayout to FrameLayout

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=412bd74b51ef

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8625827 [details] [diff] [review]
Change menu_popup LinearLayout to FrameLayout

Review of attachment 8625827 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, sergej!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/85c82cd1e3de

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85c82cd1e3de