Fix warnings in android lint output of base sub-project

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 6 obsolete attachments)

39 bytes, text/x-review-board-request
mhaigh
: review+
Details
57 bytes, text/x-github-pull-request
mcomella
: review+
Details | Review
Bug 1170884 - Use fully qualified android.R.*. r?nalexander
Attachment #8614472 - Flags: review?(nalexander)
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review8837

Ship It!
Attachment #8614471 - Flags: review?(nalexander) → review+
Comment on attachment 8614472 [details]
MozReview Request: Bug 1170884 - Use fully qualified android.R.*. r?nalexander

https://reviewboard.mozilla.org/r/9983/#review8839

Ship It!
Attachment #8614472 - Flags: review?(nalexander) → review+
Whiteboard: [leave-open]
Attachment #8614471 - Attachment description: MozReview Request: Bug 1170884 - Call super from sub-class. r?nalexander → MozReview Request: Bug 1170884 - Replace android:password w/ android:inputType. r?liuche
Attachment #8614471 - Flags: review+ → review?(liuche)
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Replace android:password w/ android:inputType. r?liuche

android:password is deprecated.
Attachment #8614472 - Attachment is obsolete: true
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review9319

Ship It!
Attachment #8614471 - Flags: review?(liuche) → review+
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Call TypedArray.recycle after use in TextSelectionHandle. r?capella
Attachment #8614471 - Attachment description: MozReview Request: Bug 1170884 - Replace android:password w/ android:inputType. r?liuche → MozReview Request: Bug 1170884 - Call TypedArray.recycle after use in TextSelectionHandle. r?capella
Attachment #8614471 - Flags: review+ → review?(markcapella)
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

wfm :)
Attachment #8614471 - Flags: review?(markcapella) → review+
Attachment #8614471 - Attachment description: MozReview Request: Bug 1170884 - Call TypedArray.recycle after use in TextSelectionHandle. r?capella → MozReview Request: Bug 1170884 - Replace "new Integer" with "Integer.valueOf". r?nalexander
Attachment #8614471 - Flags: review+ → review?(nalexander)
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Replace "new Integer" with "Integer.valueOf". r?nalexander
Attachment #8620371 - Attachment is obsolete: true
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review9615

Ship It!
Attachment #8614471 - Flags: review?(nalexander) → review+
Comment on attachment 8621230 [details] [review]
valueOf instead of new

via gh.
Attachment #8621230 - Flags: review?(nalexander) → review+
Attachment #8614471 - Attachment description: MozReview Request: Bug 1170884 - Replace "new Integer" with "Integer.valueOf". r?nalexander → MozReview Request: Bug 1170884 - Remove obsolete layout params. r=mhaigh
Attachment #8614471 - Flags: review+ → review?(mhaigh)
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Remove obsolete layout params. r=mhaigh

Via the ObsoleteLayoutParam android Lint warning. Fixed automagically by
Android Studio.
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Remove obsolete layout params. r=mhaigh

Via the ObsoleteLayoutParam android Lint warning. Fixed automagically by
Android Studio.
Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

android-lint recommends this as part of it's "Orientation" rule.
Attachment #8623441 - Flags: review?(mhaigh)
Bug 1170884 - Remove unnecessary namespace attribute. r=mhaigh

Part of android lint's "MissingPrefix" rule.
Attachment #8623456 - Flags: review?(mhaigh)
Bug 1170884 - Add title to menu item. r=mhaigh

Part of android lint's "MenuTitle" warning.

This is a stub (according to the comments) so we don't actually need a title. I
was going to suppress the lint output but since the title is the empty string
on v11+ where this value is used, I figured an empty string title should
suffice.
Attachment #8623457 - Flags: review?(mhaigh)
Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh

This falls under the InefficientWeight rule.

Changes completed via Android Studio quick-fix.
Attachment #8623458 - Flags: review?(mhaigh)
https://reviewboard.mozilla.org/r/9979/#review9981

Looks good to me.  Would like to simplify that LinearLayout to something simplier, maybe file it as a separate bug?
Attachment #8623441 - Flags: review?(mhaigh)
Comment on attachment 8623441 [details]
MozReview Request: Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

https://reviewboard.mozilla.org/r/11547/#review9977

::: mobile/android/base/resources/layout/gecko_app.xml:67
(Diff revision 1)
> +                          android:orientation="horizontal" />

This seems superfluous to me.  Looking at the code this view is only ever animated - it never has content added.  Perhaps we can make it in to a simplier ViewGroup?
Comment on attachment 8623441 [details]
MozReview Request: Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

https://reviewboard.mozilla.org/r/11547/#review9983

Ship It!
Attachment #8623441 - Flags: review+
Attachment #8614471 - Flags: review?(mhaigh) → review+
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review9985

Ship It!
Comment on attachment 8623456 [details]
MozReview Request: Bug 1170884 - Remove unnecessary namespace attribute. r=mhaigh

https://reviewboard.mozilla.org/r/11553/#review9987

Ship It!
Attachment #8623456 - Flags: review?(mhaigh) → review+
Comment on attachment 8623457 [details]
MozReview Request: Bug 1170884 - Add title to menu item. r=mhaigh

https://reviewboard.mozilla.org/r/11555/#review9989

Ship It!
Attachment #8623457 - Flags: review?(mhaigh) → review+
Comment on attachment 8623458 [details]
MozReview Request: Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh

https://reviewboard.mozilla.org/r/11557/#review9993

Ship It!
Attachment #8623458 - Flags: review?(mhaigh) → review+
https://reviewboard.mozilla.org/r/11547/#review10003

> This seems superfluous to me.  Looking at the code this view is only ever animated - it never has content added.  Perhaps we can make it in to a simplier ViewGroup?

Filed bug 1175563.
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Change inner LinearLayout to wrap_content. r=mhaigh

Inside a ScrollView. According to Android Lint:

ScrollView children must set their layout_width or layout_height attributes to
wrap_content rather than fill_parent or match_parent in the scrolling dimension

--- Who am I to argue?
Attachment #8614471 - Attachment description: MozReview Request: Bug 1170884 - Remove obsolete layout params. r=mhaigh → MozReview Request: Bug 1170884 - Change inner LinearLayout to wrap_content. r=mhaigh
Attachment #8614471 - Flags: review+ → review?(mhaigh)
Attachment #8623441 - Attachment is obsolete: true
Attachment #8623456 - Attachment is obsolete: true
Attachment #8623457 - Attachment is obsolete: true
Attachment #8623458 - Attachment is obsolete: true
Attachment #8614471 - Flags: review?(mhaigh) → review+
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review10391

Ship It!
Attachment #8614471 - Attachment description: MozReview Request: Bug 1170884 - Change inner LinearLayout to wrap_content. r=mhaigh → MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh
Attachment #8614471 - Flags: review+ → review?(mhaigh)
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Disable IconColors lint warning. r=mhaigh
Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review10541

Ship It!
Attachment #8614471 - Flags: review?(mhaigh) → review+
I'll open up some new bugs when I start to actively work on this again.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [leave-open]
You need to log in before you can comment on or make changes to this bug.