1170884 - Fix warnings in android lint output of base sub-project

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

One at a time...

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Call super from sub-class. r?nalexander

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Use fully qualified android.R.*. r?nalexander

Bug 1170884 - Use fully qualified android.R.*. r?nalexander

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review8837

Ship It!

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614472 [details]
MozReview Request: Bug 1170884 - Use fully qualified android.R.*. r?nalexander

https://reviewboard.mozilla.org/r/9983/#review8839

Ship It!

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/6657b144de7c
https://hg.mozilla.org/integration/fx-team/rev/37f093517fc0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6657b144de7c
https://hg.mozilla.org/mozilla-central/rev/37f093517fc0

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Replace android:password w/ android:inputType. r?liuche

android:password is deprecated.

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review9319

Ship It!

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/d011301ad8be

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Use fully qualified android.R.*. r?nalexander

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Call TypedArray.recycle after use in TextSelectionHandle. r?capella

Comment 12

[Mark Capella [:capella]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

wfm :)

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d011301ad8be

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/e0319ae4326c

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: valueOf instead of new

Comment 16

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Replace "new Integer" with "Integer.valueOf". r?nalexander

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e0319ae4326c

Comment 18

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review9615

Ship It!

Comment 19

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/4b2df807614e
https://hg.mozilla.org/integration/fx-team/rev/0d0244279602

Comment 20

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8621230 [details] [review]
valueOf instead of new

via gh.

Comment 21

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Remove obsolete layout params. r=mhaigh

Via the ObsoleteLayoutParam android Lint warning. Fixed automagically by
Android Studio.

Comment 22

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4b2df807614e
https://hg.mozilla.org/mozilla-central/rev/0d0244279602

Comment 23

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Remove obsolete layout params. r=mhaigh

Via the ObsoleteLayoutParam android Lint warning. Fixed automagically by
Android Studio.

Comment 24

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

android-lint recommends this as part of it's "Orientation" rule.

Comment 25

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Remove unnecessary namespace attribute. r=mhaigh

Bug 1170884 - Remove unnecessary namespace attribute. r=mhaigh

Part of android lint's "MissingPrefix" rule.

Comment 26

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Add title to menu item. r=mhaigh

Bug 1170884 - Add title to menu item. r=mhaigh

Part of android lint's "MenuTitle" warning.

This is a stub (according to the comments) so we don't actually need a title. I
was going to suppress the lint output but since the title is the empty string
on v11+ where this value is used, I figured an empty string title should
suffice.

Comment 27

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh

Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh

This falls under the InefficientWeight rule.

Changes completed via Android Studio quick-fix.

Comment 28

[Martyn Haigh (:mhaigh)]

https://reviewboard.mozilla.org/r/9979/#review9981

Looks good to me.  Would like to simplify that LinearLayout to something simplier, maybe file it as a separate bug?

Comment 29

[Martyn Haigh (:mhaigh)]

Comment on attachment 8623441 [details]
MozReview Request: Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

https://reviewboard.mozilla.org/r/11547/#review9977

::: mobile/android/base/resources/layout/gecko_app.xml:67
(Diff revision 1)
> +                          android:orientation="horizontal" />

This seems superfluous to me.  Looking at the code this view is only ever animated - it never has content added.  Perhaps we can make it in to a simplier ViewGroup?

Comment 30

[Martyn Haigh (:mhaigh)]

Comment on attachment 8623441 [details]
MozReview Request: Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh

https://reviewboard.mozilla.org/r/11547/#review9983

Ship It!

Comment 31

[Martyn Haigh (:mhaigh)]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review9985

Ship It!

Comment 32

[Martyn Haigh (:mhaigh)]

Comment on attachment 8623456 [details]
MozReview Request: Bug 1170884 - Remove unnecessary namespace attribute. r=mhaigh

https://reviewboard.mozilla.org/r/11553/#review9987

Ship It!

Comment 33

[Martyn Haigh (:mhaigh)]

Comment on attachment 8623457 [details]
MozReview Request: Bug 1170884 - Add title to menu item. r=mhaigh

https://reviewboard.mozilla.org/r/11555/#review9989

Ship It!

Comment 34

[Martyn Haigh (:mhaigh)]

Comment on attachment 8623458 [details]
MozReview Request: Bug 1170884 - Use 0dp for layout_w/h for perf reasons. r=mhaigh

https://reviewboard.mozilla.org/r/11557/#review9993

Ship It!

Comment 35

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/11547/#review10003

> This seems superfluous to me.  Looking at the code this view is only ever animated - it never has content added.  Perhaps we can make it in to a simplier ViewGroup?

Filed bug 1175563.

Comment 36

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/43b338ccbaa9
https://hg.mozilla.org/integration/fx-team/rev/67b89eefbb56
https://hg.mozilla.org/integration/fx-team/rev/9213957d166d
https://hg.mozilla.org/integration/fx-team/rev/759bfacec785
https://hg.mozilla.org/integration/fx-team/rev/de50d9ec609e

Comment 37

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/9979/#review10007

Filed bug 1175566.

Comment 38

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43b338ccbaa9
https://hg.mozilla.org/mozilla-central/rev/67b89eefbb56
https://hg.mozilla.org/mozilla-central/rev/9213957d166d
https://hg.mozilla.org/mozilla-central/rev/759bfacec785
https://hg.mozilla.org/mozilla-central/rev/de50d9ec609e

Comment 39

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Change inner LinearLayout to wrap_content. r=mhaigh

Inside a ScrollView. According to Android Lint:

ScrollView children must set their layout_width or layout_height attributes to
wrap_content rather than fill_parent or match_parent in the scrolling dimension

--- Who am I to argue?

Comment 40

[Martyn Haigh (:mhaigh)]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review10391

Ship It!

Comment 41

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/170d033d4e15

Comment 42

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Bug 1170884 - Disable IconColors lint warning. r=mhaigh

Comment 43

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/170d033d4e15

Comment 44

[Martyn Haigh (:mhaigh)]

Comment on attachment 8614471 [details]
MozReview Request: Bug 1170884 - Disable IconColors lint warning. r=mhaigh

https://reviewboard.mozilla.org/r/9981/#review10541

Ship It!

Comment 45

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/f96be24437af

Comment 46

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f96be24437af

Comment 47

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'll open up some new bugs when I start to actively work on this again.