1175776 - GMPChild should expect exactly one RecvBeginAsyncShutdown if it is async-shutdown-capable

Status: RESOLVED INVALID

(Core :: Audio/Video: GMP, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Spawned from bug 1173631 comment 9:
"""
> [...] since bug 1174064 tries to ensure that
> we never reuse a GMP once it's started its async shutdown, we should never
> end up doing async shutdown twice. If we do that's a bug, which arguably we
> should MOZ_DIAGNOSTIC_ASSERT to detect.
After discussion with Chris, we've decided to leave this patch as-is, and spawn a separate bug to tackle expected invariants around shutdown...
"""

Basically, GMPParent only requests async-shutdown if the child is capable of it, and it should happen exactly once (no more, no less).
These expectations should be expressed by some asserts in the child.

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Async shutdown is no more, so resolving.