Closed Bug 1176216 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_async_distribution.js | search_initialized - [search_initialized : 29] "bug645970" == "override"

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird40 wontfix, thunderbird41 fixed, thunderbird42 fixed, thunderbird_esr38 unaffected)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 42.0
Tracking Flags:
Tracking Status
thunderbird40 --- wontfix
thunderbird41 --- fixed
thunderbird42 --- fixed
thunderbird_esr38 --- unaffected

People

(Reporter: mkmelin, Assigned: rkent)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Copy changes from bug 1109354
3.38 KB, patch
mkmelin
: review+
rkent
: approval-comm-beta+
Details | Diff | Splinter Review
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_async_distribution.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_async_distribution.js | search_initialized - [search_initialized : 29] "bug645970" == "override" TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_sync_distribution.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_sync_distribution.js | run_test - [run_test : 25] "bug645970" == "override" http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2015/06/2015-06-18-03-02-03-comm-central/comm-central_ubuntu32_vm_test-xpcshell-bm01-tests1-linux32-build2.txt.gz 05:12:02 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_async_distribution.js | search_initialized - [search_initialized : 29] "bug645970" == "override" 05:12:02 INFO - /builds/slave/test/build/tests/xpcshell/tests/toolkit/components/search/tests/xpcshell/test_async_distribution.js:search_initialized:29 05:12:02 INFO - resource://gre/components/nsSearchService.js:onSuccess:4308 05:12:02 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:920 05:12:02 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:799 05:12:02 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.scheduleWalkerLoop/<:738 05:12:02 INFO - null:null:0 05:12:02 INFO - exiting test
I believe that we need to implement NS_APP_DISTRIBUTION_SEARCH_DIR_LIST from the blocking bug.
Blocks: 1109354
All tests in the search directory pass with this. I did not know any way to test that a search provider is being properly provided to Thunderbird in a non-test run (if we even have any use for search providers anymore).
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Attachment #8644143 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8644143 [details] [diff] [review] Copy changes from bug 1109354 Review of attachment 8644143 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thx! r=mkmelin
Attachment #8644143 - Flags: review?(mkmelin+mozilla) → review+
http://hg.mozilla.org/comm-central/rev/9cbf536201f4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8644143 [details] [diff] [review] Copy changes from bug 1109354 I'll land in beta and aurora after confirmed that central test failures are gone.
Attachment #8644143 - Flags: approval-comm-beta?
Attachment #8644143 - Flags: approval-comm-aurora?
Kent, what is the status on this? Looks like test failures are gone.
Flags: needinfo?(rkent)
They just need landing. I don't pay much attention to beta and aurora, but you may approve and land if you want.
Flags: needinfo?(rkent)
Comment on attachment 8644143 [details] [diff] [review] Copy changes from bug 1109354 Unfortunately I don't have the bits to plus approval-comm-* flags, but I'll take your comment as an approval. Maybe you can flip the flag for completeness. It has already trickled down to comm-aurora, here is the push for comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/c88ee335fb93
Attachment #8644143 - Flags: approval-comm-aurora?
It's ridiculous that you have comm-esr38 approval but not aurora and beta. Can you to fix that?
Attachment #8644143 - Flags: approval-comm-beta? → approval-comm-beta+
status-thunderbird40: affected → wontfix
status-thunderbird41: affected → fixed
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: