1176294 - Allow setting RUSTC from the enviroment

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1175359#c15 many program paths can be passed to configure through the environment. Have --enable-rust check $RUSTC before a generic path.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Allow setting RUSTC from the environment

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8624805 [details] [diff] [review]
Allow setting RUSTC from the environment

Review of attachment 8624805 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Ralph Giles (:rillian)]

Green on try (pushlog doesn't show the commit but it's in the history as https://hg.mozilla.org/try/rev/e3ea9cdfafa4)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=348479922766

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8624805 [details] [diff] [review]
Allow setting RUSTC from the environment

Review of attachment 8624805 [details] [diff] [review]:
-----------------------------------------------------------------

This shouldn't be needed, because what MOZ_CHECK_PROGS(RUSTC, rustc) expands to is (skipping irrelevant stuff):

(...)
  case "$RUSTC" in
  /*)
  ac_cv_path_RUSTC="$RUSTC" # Let the user override the test with a path.
  ;;
  ?:/*)
  ac_cv_path_RUSTC="$RUSTC" # Let the user override the test with a dos path.
  ;;
  *)
  IFS="${IFS=   }"; ac_save_ifs="$IFS"; IFS=":"
  ac_dummy="$PATH"
  for ac_dir in $ac_dummy; do
    test -z "$ac_dir" && ac_dir=.
    if test -f $ac_dir/$ac_word; then
      ac_cv_path_RUSTC="$ac_dir/$ac_word"
      break
    fi
  done
  IFS="$ac_save_ifs"
  ;;
esac
(...)

IOW, then RUSTC is already set, its value is used.

Comment 5

[Ralph Giles (:rillian)]

Interesting. This behaviour comes from AC_PATH_PROGS, and while still present in normal autoconf isn't documented.