Closed Bug 1176729 Opened 4 years ago Closed 4 years ago

Remove redundant env checks in MOZ_PATH_PROGS

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox41 affected)

RESOLVED WONTFIX
Tracking Status
firefox41 --- affected

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

We occasionally have MOZ_PATH_PROGS(FOO, $FOO foo other-foo) to allow overriding the FOO choice.

This is redundant for full-path values of FOO in the environment because MOZ_PATH_PROGS wraps AC_PATH_PROGS which checks $FOO first if it looks like an absolute path.

This means PERL=perl-5.12 will no longer work, instead you'll need PERL=/usr/local/bin/perl-5.12 or whatever.

This confused me into adding the same style for RUSTC in bug 1176294.
If we only want absolute paths, we should be consistent about it.
Attachment #8625315 - Flags: review?(mh+mozilla) → review+
QA Contact: giles
Assignee: nobody → giles
QA Contact: giles
had to back this out for bustages like https://treeherder.mozilla.org/logviewer.html#?job_id=11047943&repo=mozilla-inbound

03:12 < catlee> 22:12:17 INFO - cl : Command line warning D9024 : unrecognized source file type 'c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/xpcom/reflect/xptcall/md/win32/xptcstubs_asm_x86_64.asm', object file 
                assumed 
03:13 < catlee> central does something like this:
03:13 < catlee> 05:50:06     INFO -  ml64.exe -Foxptcstubs_asm_x86_64.obj   -Zi   -c c:/builds/moz2_slave/m-cen-w64-ntly-000000000000000/build/src/xpcom/reflect/xptcall/md/win32/xptcstubs_asm_x86_64.asm
03:15 < catlee> indeed
03:15 < catlee> https://dxr.mozilla.org/mozilla-central/source/build/autoconf/compiler-opts.m4#37
Flags: needinfo?(giles)
What do you want to do here glandium? Windows build at least sets AS to something in path. Should $AS be special? Drop the patch entirely?
Flags: needinfo?(giles) → needinfo?(mh+mozilla)
Let's just won't fix this. Not worth chasing.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.